Mail archive
alpine-aports

Re: [alpine-aports] [PATCH] testing/tomcat-native: new aport

From: Natanael Copa <ncopa_at_alpinelinux.org>
Date: Thu, 1 Jan 2015 16:57:10 +0100

On Wed, 31 Dec 2014 07:08:59 +0000
Sean Summers <seansummers_at_gmail.com> wrote:

> http://tomcat.apache.org/native-doc/
> native resources optional component for Apache Tomcat
> ---
> testing/tomcat-native/APKBUILD | 43 +++++++++++++++++++++++
> testing/tomcat-native/tomcat-native.post-install | 2 ++
> testing/tomcat-native/tomcat-native.pre-deinstall | 2 ++
> 3 files changed, 47 insertions(+)
> create mode 100644 testing/tomcat-native/APKBUILD
> create mode 100644 testing/tomcat-native/tomcat-native.post-install
> create mode 100644 testing/tomcat-native/tomcat-native.pre-deinstall

Hi, thanks. Applied, but i have a few questions below.

> +depends="apr openssl openjdk7-jre-base"

is the apr and openssl dependency due to a library or due to the need
for some executable?

Library dependencies are normally autodetected.

> diff --git a/testing/tomcat-native/tomcat-native.post-install b/testing/tomcat-native/tomcat-native.post-install
> new file mode 100644
> index 0000000..1774a04
> --- /dev/null
> +++ b/testing/tomcat-native/tomcat-native.post-install
> _at_@ -0,0 +1,2 @@
> +#!/bin/sh
> +ln -s libtcnative-1.so.0 /usr/lib/libtcnative-1.so

why is the symlink created on install and removed on deinstall instead
of shipped as a part of the package?

why not something like:

diff --git a/testing/tomcat-native/APKBUILD b/testing/tomcat-native/APKBUILD
index 6f121b7..1e0da15 100644
--- a/testing/tomcat-native/APKBUILD
+++ b/testing/tomcat-native/APKBUILD
_at_@ -7,10 +7,10 @@ pkgdesc="native resources optional component for Apache Tomcat"
 url="http://tomcat.apache.org/native-doc/"
 arch="all"
 license="ASL 2.0"
-depends="apr openssl openjdk7-jre-base"
+depends="openjdk7-jre-base"
 depends_dev="apr-dev openssl-dev openjdk7"
 makedepends="${depends_dev}"
-install="${pkgname}.post-install ${pkgname}.pre-deinstall"
+install=""
 subpackages="${pkgname}-dev"
 source="http://mirrors.gigenet.com/apache/tomcat/tomcat-connectors/native/${pkgver}/source/${pkgname}-${pkgver}-src.tar.gz
 ${install}
_at_@ -29,7 +29,7 @@ package() {
         cd "src/${_builddir}"
         make DESTDIR="${pkgdir}" install || return 1
        rm -f ${pkgdir}/usr/lib/*.la || true
- rmdir ${pkgdir}/usr/* 2>/dev/null || true
+ ln -s libtcnative-1.so.0 "$pkgdir"/usr/lib/libtcnative-1.so
 }
 
 md5sums="90b4f55d9e3f3614c7b780500268570b
 tomcat-native-1.1.32-src.tar.gz



-nc


---
Unsubscribe:  alpine-aports+unsubscribe_at_lists.alpinelinux.org
Help:         alpine-aports+help_at_lists.alpinelinux.org
---
Received on Thu Jan 01 2015 - 16:57:10 GMT