Mail archive
alpine-aports

Re: [alpine-aports] [PATCH] main/busybox: prevent abuild from complaining about /tmp during build

From: Natanael Copa <ncopa_at_alpinelinux.org>
Date: Tue, 28 Jul 2015 10:33:54 +0200

On Mon, 27 Jul 2015 23:10:10 +0200
Sören Tempel <soeren+git_at_soeren-tempel.net> wrote:

> ---
> main/busybox/APKBUILD | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/main/busybox/APKBUILD b/main/busybox/APKBUILD
> index a950f84..0d0ebb7 100644
> --- a/main/busybox/APKBUILD
> +++ b/main/busybox/APKBUILD
> _at_@ -82,7 +82,6 @@ build() {
> make -C "$_sdir" O="$PWD" silentoldconfig || return 1
> make || return 1
> mv busybox busybox.static
> -
> }
>
> package() {
> _at_@ -95,7 +94,7 @@ package() {
> # we need /bin/sh to be able to execute post-install
> ln -s /bin/busybox "$pkgdir"/bin/sh
>
> - #ifupdown needs those dirs to be present
> + # ifupdown needs those dirs to be present
> mkdir -p \
> "$pkgdir"/etc/network/if-down.d \
> "$pkgdir"/etc/network/if-post-down.d \
> _at_@ -104,6 +103,9 @@ package() {
> "$pkgdir"/etc/network/if-pre-up.d \
> "$pkgdir"/etc/network/if-up.d \
> || return 1
> +
> + # prevent abuild from complaining about /tmp
> + rm -rf "$pkgdir/tmp"

NACK.

If we want remove it, then better not create it (the package function
does mkdir).

But I think we created it for a reason in the first place. git blame
gave me commit 8b60075.
http://git.alpinelinux.org/cgit/aports/commit/?id=8b60075

Which explains that we need /tmp early for install script when
bootstrapping a new root with apkovl.

-nc


---
Unsubscribe:  alpine-aports+unsubscribe_at_lists.alpinelinux.org
Help:         alpine-aports+help_at_lists.alpinelinux.org
---
Received on Tue Jul 28 2015 - 10:33:54 GMT