Mail archive
alpine-aports

Re: [alpine-aports] [PATCH 3/3] main/ssmtp: fix usage of getaddrinfo

From: Isaac Dunham <ibid.ag_at_gmail.com>
Date: Tue, 28 Jul 2015 17:12:07 -0700

On Mon, Jul 27, 2015 at 08:26:04PM +0200, Sören Tempel wrote:
> diff --git a/main/ssmtp/inet6-getaddrinfo.patch b/main/ssmtp/inet6-getaddrinfo.patch
> +++ b/main/ssmtp/inet6-getaddrinfo.patch
> _at_@ -0,0 +1,12 @@
> +diff -up ssmtp.orig/ssmtp.c ssmtp/ssmtp.c
> +--- ssmtp.orig/ssmtp.c 2009-11-23 10:55:11.000000000 +0100
> ++++ ssmtp/ssmtp.c 2015-07-27 17:34:12.498140804 +0200
> +_at_@ -1157,7 +1157,7 @@ int smtp_open(char *host, int port)
> + snprintf(servname, sizeof(servname), "%d", port);
> +
> + /* Check we can reach the host */
> +- if (getaddrinfo(host, servname, &hints, &ai0)) {
> ++ if (getaddrinfo(host, servname, &hints, &ai0) != 0) {
> + log_event(LOG_ERR, "Unable to locate %s", host);
> + return(-1);
> + }

I'm wondering what this is supposed to do.
In C, "if (function(args))" means "if ((function(args)) != 0)",
so the change doesn't mean anything different.

Thanks,
Isaac Dunham


---
Unsubscribe:  alpine-aports+unsubscribe_at_lists.alpinelinux.org
Help:         alpine-aports+help_at_lists.alpinelinux.org
---
Received on Tue Jul 28 2015 - 17:12:07 GMT