On 27.08.15, systmkor wrote:
> package() {> cd "$_builddir"> - make install DESTDIR="$pkgdir"> - install -Dm755 ../openntpd.initd "$pkgdir/etc/init.d/$pkgname"> - install -Dm644 ../openntpd.confd "$pkgdir/etc/conf.d/$pkgname"> + make install DESTDIR="$pkgdir" || return 1> + mkdir -p "$pkgdir"/var/empty || return 1> + install -Dm755 "$srcdir"/openntpd.initd "$pkgdir"/etc/init.d/"$pkgname" || return 1> + install -Dm644 "$srcdir"/openntpd.confd "$pkgdir"/etc/conf.d/"$pkgname" || return 1> }
This would make the OpenNTPD package the owner of /var/empty. I don't
think that this is a good idea.
Sören.
---
Unsubscribe: alpine-aports+unsubscribe@lists.alpinelinux.org
Help: alpine-aports+help@lists.alpinelinux.org
---
On Sat, 29 Aug 2015 12:15:44 +0200
Sören Tempel <soeren@soeren-tempel.net> wrote:
> This would make the OpenNTPD package the owner of /var/empty. I don't> think that this is a good idea.
Okay, so what are you saying? Because I thought I wrote what you
suggested in the last patch. And now you are suggesting to do what you
said I should do last time. [1]
If you look at the OpenSSH APKBUILD file it creates /var/empty in it's
package function. So I'm not sure what you are actually suggesting.
# References
[1] Last Patch Discussion
On Thu, 27 Aug 2015 10:48:02 -0700
Orion Miller <systmkor@gmail.com> wrote:
> > The OpenSSH aports creates the /var/empty directory in its OpenRC> > services[1], maybe it would be a good idea to do that here as well> > for the sake of consistency?>> I thought if I did that it would cause a package ownership> contention over that specific file (i.e. a directory). I'll try it. :D
--
keybase.io/systmkor
---
Unsubscribe: alpine-aports+unsubscribe@lists.alpinelinux.org
Help: alpine-aports+help@lists.alpinelinux.org
---
On 29.08.15, Orion Miller wrote:
> Okay, so what are you saying? Because I thought I wrote what you> suggested in the last patch. And now you are suggesting to do what you> said I should do last time. [1]
No, I suggested to create that directory in the OpenRC service not in
the package function. Did you even read your own reference?
On 29.08.15, Orion Miller wrote:
> If you look at the OpenSSH APKBUILD file it creates /var/empty in it's> package function. So I'm not sure what you are actually suggesting.
Turns out: OpenSSH creates /var/empty in the package function and it
creates it again in the OpenRC service:
See:
- http://git.alpinelinux.org/cgit/aports/tree/main/openssh/sshd.initd#n39
- http://git.alpinelinux.org/cgit/aports/tree/main/openssh/APKBUILD#n75
I personally believe that this is a fault in the OpenSSH aport. Still
the question remains what the best way to create that directory is…I
personally dislike the creation of /var/empty in the package() function.
Maybe we should simply create that in alpine-baselayout?
---
Unsubscribe: alpine-aports+unsubscribe@lists.alpinelinux.org
Help: alpine-aports+help@lists.alpinelinux.org
---
On Thu, 3 Sep 2015 11:17:52 +0200
Sören Tempel <soeren@soeren-tempel.net> wrote:
> On 29.08.15, Orion Miller wrote:> > Okay, so what are you saying? Because I thought I wrote what you> > suggested in the last patch. And now you are suggesting to do what you> > said I should do last time. [1]> > No, I suggested to create that directory in the OpenRC service not in> the package function. Did you even read your own reference?> > On 29.08.15, Orion Miller wrote:> > If you look at the OpenSSH APKBUILD file it creates /var/empty in it's> > package function. So I'm not sure what you are actually suggesting.> > Turns out: OpenSSH creates /var/empty in the package function and it> creates it again in the OpenRC service:> > See:> - http://git.alpinelinux.org/cgit/aports/tree/main/openssh/sshd.initd#n39> - http://git.alpinelinux.org/cgit/aports/tree/main/openssh/APKBUILD#n75> > I personally believe that this is a fault in the OpenSSH aport. Still> the question remains what the best way to create that directory is…I> personally dislike the creation of /var/empty in the package() function.
I think it is perfectly fine that packages that uses a directory
creates it.
> Maybe we should simply create that in alpine-baselayout?
I think we should and I just did.
Thanks!
-nc
---
Unsubscribe: alpine-aports+unsubscribe@lists.alpinelinux.org
Help: alpine-aports+help@lists.alpinelinux.org
---
Thank you both. Sorry Sören for the miscommunication.
For me this raises a question about package management. Should packages possibly have files that they require/depend on but don't necessarily need to own? The /var/empty directory between OpenSSH and OpenNTPD I think is a good example.
What are your thoughts? Should we continue this in alpine-devel?
---
Unsubscribe: alpine-aports+unsubscribe@lists.alpinelinux.org
Help: alpine-aports+help@lists.alpinelinux.org
---