Mail archive
alpine-aports

Re: [alpine-aports] [PATCH] main/openvswitch: fix ifupdown script

From: Natanael Copa <ncopa_at_alpinelinux.org>
Date: Tue, 25 Aug 2015 09:47:47 +0200

On Mon, 17 Aug 2015 22:39:22 +0000
Stuart Cardall <developer_at_it-offshore.co.uk> wrote:

> --- a/main/openvswitch/ifupdown.sh
> +++ b/main/openvswitch/ifupdown.sh
> _at_@ -29,7 +29,9 @@ if (ovs_vsctl --version) > /dev/null 2>&1; then :; else
> exit 0
> fi
>
> -if /etc/init.d/ovs-vswitchd status > /dev/null 2>&1; then :; else
> +if ! /etc/init.d/ovs-vswitchd status &>/dev/null; then
> + /etc/init.d/ovs-modules start
> + /etc/init.d/ovsdb-server start
> /etc/init.d/ovs-vswitchd start
> fi
>

Why don't we add ovsdb-server and ovs-modules as dependencies for ovs-vswitchd?

If it is not a hard dependency (but a configurable, soft dependency),
then maybe the /etc/conf.d/ovs-vswitchd should have:

  rc_depend="ovs-modules ovsdb-server"

I think hardcoding it in the ifupdown.sh script is wrong in case the
dependencies for the ovs-vswitchd service changes in future version.


-nc


---
Unsubscribe:  alpine-aports+unsubscribe_at_lists.alpinelinux.org
Help:         alpine-aports+help_at_lists.alpinelinux.org
---
Received on Tue Aug 25 2015 - 09:47:47 GMT