Mail archive
alpine-aports

Re: [alpine-aports] [PATCH] main/openvswitch: fix ifupdown script

From: IT Developer <developer_at_it-offshore.co.uk>
Date: Wed, 26 Aug 2015 00:07:08 +0100

Adding rc_depends to /etc/conf.d/ovs-vswitchd did not start the depends.

Starting init scripts from within a shell script does not start the
depends so I revised the ifupdown script to loop through:

DEPENDS=$(/lib/rc/bin/rc-depend -t ineed -qq ovs-vswitchd)

2 new ovs patches sent a little earlier.

Stuart.

On 25/08/15 08:47, Natanael Copa wrote:
> On Mon, 17 Aug 2015 22:39:22 +0000
> Stuart Cardall <developer_at_it-offshore.co.uk> wrote:
>
>> --- a/main/openvswitch/ifupdown.sh
>> +++ b/main/openvswitch/ifupdown.sh
>> _at__at_ -29,7 +29,9 @@ if (ovs_vsctl --version) > /dev/null 2>&1; then :; else
>> exit 0
>> fi
>>
>> -if /etc/init.d/ovs-vswitchd status > /dev/null 2>&1; then :; else
>> +if ! /etc/init.d/ovs-vswitchd status &>/dev/null; then
>> + /etc/init.d/ovs-modules start
>> + /etc/init.d/ovsdb-server start
>> /etc/init.d/ovs-vswitchd start
>> fi
>>
> Why don't we add ovsdb-server and ovs-modules as dependencies for ovs-vswitchd?
>
> If it is not a hard dependency (but a configurable, soft dependency),
> then maybe the /etc/conf.d/ovs-vswitchd should have:
>
> rc_depend="ovs-modules ovsdb-server"
>
> I think hardcoding it in the ifupdown.sh script is wrong in case the
> dependencies for the ovs-vswitchd service changes in future version.
>
>
> -nc




---
Unsubscribe:  alpine-aports+unsubscribe_at_lists.alpinelinux.org
Help:         alpine-aports+help_at_lists.alpinelinux.org
---
Received on Wed Aug 26 2015 - 00:07:08 GMT