Mail archive
alpine-aports

Re: [alpine-aports] [PATCH] Adding XDebug for PHP

From: Sören Tempel <soeren_at_soeren-tempel.net>
Date: Thu, 3 Sep 2015 11:05:01 +0200

On 01.09.15, Michael Venezia wrote:
> ---
> main/php-xdebug/APKBUILD | 52 ++++++++++++++++++++++++++++++++++++++++++++++
> main/php-xdebug/xdebug.ini | 6 ++++++

Again: This needs to be committed to testing/ not to main/. Besides the
commit message should be "testing/php-xdebug: new aport".

On 01.09.15, Michael Venezia wrote:
> +# Contributor:
> +# Maintainer:

It would be kind of great if this package had a maintainer, don't you
want to maintain this package?

On 01.09.15, Michael Venezia wrote:
> +arch="x86_64"

This package should work on x86 and arm too. Please verify this and use
arch="all" if it is the case.

On 01.09.15, Michael Venezia wrote:
> +license="GPL"

According to the website <http://www.xdebug.org/license.php> xdebug is
licensed under a custom license and not under the GPL. Even if it is
licensed under the GPL then please specify the GPL version e.g. GPL3.

On 01.09.15, Michael Venezia wrote:
> +depends_dev=""
> +makedepends="$depends_dev php-dev autoconf automake flex bison gawk"

Please move php-dev from makedepends to depends_dev.

On 01.09.15, Michael Venezia wrote:
> +build() {
> + cd "$_builddir"
> + phpize --clean && phpize || return 1
> + ./configure \
> + --build=$CBUILD \
> + --host=$CHOST \
> + --prefix=/usr \
> + || return 1
> + make -j1 || return 1
> +}

Why did you explicitly set the amount of makejobs to 1? If more than one
makejob can be used than please add a comment explaining why this is the
case.

On 01.09.15, Michael Venezia wrote:
> +package() {
> + cd "$_builddir"
> + make -j1 install INSTALL_ROOT="$pkgdir" || return 1
> + install -Dm644 "$srcdir"/xdebug.ini \
> + "$pkgdir"/etc/php/conf.d/xdebug.ini || return 1
> +}

Again: Why did you limit the amount of makejobs to 1?

Sören.


---
Unsubscribe:  alpine-aports+unsubscribe_at_lists.alpinelinux.org
Help:         alpine-aports+help_at_lists.alpinelinux.org
---
Received on Thu Sep 03 2015 - 11:05:01 UTC