Mail archive
alpine-aports

Re: [alpine-aports] [PATCH v3] testing/fbida: new aport

From: Sören Tempel <soeren_at_soeren-tempel.net>
Date: Wed, 9 Sep 2015 21:32:33 +0200

On 08.09.15, Isaac Dunham wrote:
> Now, a couple comments on substance:
> - the use of _tool and _tool_doc is rather odd, but there's only one point
> where I'd actually suggest something different:
> for fbida-fbgs, call a new function "fbgs", which will in turn call _tool.

I think the _tool and _tool_doc functions are a nice way to prevent
duplication. Creating a new "fbgs" function which invokes _tool sounds
like a good idea to me, but both approaches work and don't make a big
difference to me.

On 08.09.15, Isaac Dunham wrote:
> - package naming is somewhat odd, and it's certainly more granular than
> usual: the usual split is fbi / ida (+ -doc for each)

The fbida website <https://www.kraxel.org/blog/linux/fbida/>
differentiates between 5 Tools. Therefore it seemed very intuitive to me
to also create a subpackage for each of those tools, even though I
didn't package thumbnail.cgi yet.

Since it's pretty easy to split the package with the _tool
function I don't see any reason not to do it. It might be unusual but I
think it's the best way to split it.

On 08.09.15, Isaac Dunham wrote:
> - RESDIR should not be set to /usr/share/$pkgname:
> no one would think to look for the application defaults there.
> The standard location is /etc/X11/app-defaults/<resource name>.

You are right, I will fix that tomorrow. Furthermore that file should
probably be moved to the ida subpackage.

Sören.


---
Unsubscribe:  alpine-aports+unsubscribe_at_lists.alpinelinux.org
Help:         alpine-aports+help_at_lists.alpinelinux.org
---
Received on Wed Sep 09 2015 - 21:32:33 GMT