Mail archive
alpine-aports

Re: [alpine-aports] [PATCH] testing/oath-toolkit: new aport

From: Sören Tempel <soeren_at_soeren-tempel.net>
Date: Fri, 25 Sep 2015 16:13:22 +0200

Noticed some more things on a second look:

On 24.09.15, systmkor wrote:
> +package() {
> + cd "$_builddir"
> + make DESTDIR="$pkgdir" install || return 1
> +
> + install -D -m 644 COPYING "$pkgdir/usr/share/licenses/$pkgname/LICENSE" || return 1
> + # libpskc & liboath use the same LICENSE and libpskc doesn't have a COPYING file in it's subdir
> + install -D -m 644 liboath/COPYING "$pkgdir/usr/share/licenses/liboath/LICENSE" || return 1
> + install -D -m 644 liboath/COPYING "$pkgdir/usr/share/licenses/libpskc/LICENSE" || return 1
> + # oathtool & pskctool use the same LICENSE and pskctool doesn't have a COPYING file in it's subdir
> + install -D -m 644 oathtool/COPYING "$pkgdir/usr/share/licenses/oathtool/LICENSE" || return 1
> + install -D -m 644 oathtool/COPYING "$pkgdir/usr/share/licenses/pskctool/LICENSE" || return 1
> + install -D -m 644 pam_oath/COPYING "$pkgdir/usr/share/licenses/pam-oath/LICENSE" || return 1
> +
> + install -D -m 644 README "$pkgdir/usr/share/doc/$pkgname/README" || return 1
> + install -D -m 644 AUTHORS "$pkgdir/usr/share/doc/$pkgname/AUHTORS" || return 1
> + install -D -m 644 pam_oath/README "$pkgdir/usr/share/doc/pam-oath/README" || return 1
> + install -D -m 644 libpskc/README "$pkgdir/usr/share/doc/libpskc/README" || return 1
> + rm -f "$pkgdir"/usr/lib/*.la
> +}

Removing *.la files manually isn't necessary they are removed
automatically unless you use the 'libtool' option.

On 24.09.15, systmkor wrote:
> +doc() {
> + arch="noarch"
> + depends="
> + liboath-doc=$pkgver-r$pkgrel
> + libpskc-doc=$pkgver-r$pkgrel
> + oathtool-doc=$pkgver-r$pkgrel
> + pskctool-doc=$pkgver-r$pkgrel
> + pam-oath-doc=$pkgver-r$pkgrel
> + "
> + provides="oath-toolkit-doc=$pkgver-r$pkgrel"
> + pkgdesc="oath-toolkit (documentation)"
> + mkdir -p ${subpkgdir}/usr/share/doc || return 1
> + mv ${pkgdir}/usr/share/doc/oath-toolkit ${subpkgdir}/usr/share/doc/ || return 1
> +}

Why are you overwriting the default doc subpackage function provided by
abuild? And why does this doc function depend on other doc subpackages?

On 24.09.15, systmkor wrote:
> +dev() {
> + depends="
> + liboath=$pkgver-r$pkgrel liboath-doc=$pkgver-r$pkgrel liboath-dev=$pkgver-r$pkgrel
> + libpskc=$pkgver-r$pkgrel libpskc-doc=$pkgver-r$pkgrel libpskc-dev=$pkgver-r$pkgrel
> + oathtool=$pkgver-r$pkgrel oathtool-doc=$pkgver-r$pkgrel oathtool-dev=$pkgver-r$pkgrel
> + pskctool=$pkgver-r$pkgrel pskctool-doc=$pkgver-r$pkgrel pskctool-dev=$pkgver-r$pkgrel
> + pam-oath=$pkgver-r$pkgrel pam-oath-doc=$pkgver-r$pkgrel
> + "
> + provides="oath-toolkit-dev=$pkgver-r$pkgrel"
> + pkgdesc="The OATH Toolkit provide components for building one-time password authentication systems. (development files)"
> + mkdir -p ${subpkgdir} || return 1
> +}

Again: Why don't you use the default dev subpackage function provided by
abuild, the depends here can be specified in the depends_dev variable.

Sören.


---
Unsubscribe:  alpine-aports+unsubscribe_at_lists.alpinelinux.org
Help:         alpine-aports+help_at_lists.alpinelinux.org
---
Received on Fri Sep 25 2015 - 16:13:22 GMT