Mail archive
alpine-aports

Re: [alpine-aports] [PATCH] testing/oath-toolkit: new aport

From: Isaac Dunham <ibid.ag_at_gmail.com>
Date: Fri, 25 Sep 2015 18:58:29 -0700

On Fri, Sep 25, 2015 at 04:13:22PM +0200, Sören Tempel wrote:
> On 24.09.15, systmkor wrote:
> > +doc() {
> > + arch="noarch"
> > + depends="
> > + liboath-doc=$pkgver-r$pkgrel
> > + libpskc-doc=$pkgver-r$pkgrel
> > + oathtool-doc=$pkgver-r$pkgrel
> > + pskctool-doc=$pkgver-r$pkgrel
> > + pam-oath-doc=$pkgver-r$pkgrel
> > + "
> > + provides="oath-toolkit-doc=$pkgver-r$pkgrel"
> > + pkgdesc="oath-toolkit (documentation)"
> > + mkdir -p ${subpkgdir}/usr/share/doc || return 1
> > + mv ${pkgdir}/usr/share/doc/oath-toolkit ${subpkgdir}/usr/share/doc/ || return 1
> > +}
>
> Why are you overwriting the default doc subpackage function provided by
> abuild? And why does this doc function depend on other doc subpackages?

It seems this is so you get an oath-toolkit-doc package that drags in all
the documentation.

> On 24.09.15, systmkor wrote:
> > +dev() {
> > + depends="
> > + liboath=$pkgver-r$pkgrel liboath-doc=$pkgver-r$pkgrel liboath-dev=$pkgver-r$pkgrel
> > + libpskc=$pkgver-r$pkgrel libpskc-doc=$pkgver-r$pkgrel libpskc-dev=$pkgver-r$pkgrel
> > + oathtool=$pkgver-r$pkgrel oathtool-doc=$pkgver-r$pkgrel oathtool-dev=$pkgver-r$pkgrel
> > + pskctool=$pkgver-r$pkgrel pskctool-doc=$pkgver-r$pkgrel pskctool-dev=$pkgver-r$pkgrel
> > + pam-oath=$pkgver-r$pkgrel pam-oath-doc=$pkgver-r$pkgrel
> > + "
> > + provides="oath-toolkit-dev=$pkgver-r$pkgrel"
> > + pkgdesc="The OATH Toolkit provide components for building one-time password authentication systems. (development files)"
> > + mkdir -p ${subpkgdir} || return 1
> > +}
>
> Again: Why don't you use the default dev subpackage function provided by
> abuild, the depends here can be specified in the depends_dev variable.

This seems to be a convenience package for if you want "everything for
developing with the OATH toolkit".


I am somewhat suspicious that needing two metapackages for development
indicates overly aggressive splitting-up.

systmkor, could you give some justification for splitting it into so many
libraries?

How much space does each library take when installed?
Does one of the libraries have more dependencies than another?
Is it likely that someone will link to one library but not the other?

(If space is not in the multi-megabyte range, it's probably too much
division--unless you have a library which some packages use alone
with a smaller set of dependencies.)

Thanks,
Isaac Dunham



---
Unsubscribe:  alpine-aports+unsubscribe_at_lists.alpinelinux.org
Help:         alpine-aports+help_at_lists.alpinelinux.org
---
Received on Fri Sep 25 2015 - 18:58:29 GMT