Mail archive
alpine-aports

Re: [alpine-aports] Re: [PATCH] testing/twemproxy: new aport

From: Natanael Copa <ncopa_at_alpinelinux.org>
Date: Thu, 22 Oct 2015 08:46:11 +0200

Hi,

Thanks for your patch. Unfortunally, your mailer mangles the patch.
Thunderbird incorrectly believes that it will be easier for git am to
read the email if the long lines are wrapped.

On Thu, 22 Oct 2015 00:47:43 +0530
Yagnesh Mistry <ysh_at_live.in> wrote:

> Removed the doc() function, using the default doc now.
> Fixed indentation at places.
> Using the sample initd from the original developer, removed unnecessary
> code from initd script.
>
> https://github.com/twitter/twemproxy
> A fast, light-weight proxy for memcached and redis

...

> +package() {
> + cd "$_builddir"
> + make DESTDIR="$pkgdir" install || return 1
> + install -m644 -D "$srcdir"/$pkgname-$pkgver/conf/nutcracker.yml \
> + "$pkgdir"/etc/$akaname/nutcracker.yml || return 1
> + install -m644 -D
> "$srcdir"/$pkgname-$pkgver/conf/nutcracker.leaf.yml \
> + "$pkgdir"/etc/$akaname/nutcracker.leaf.yml || return 1
> + install -m644 -D
> "$srcdir"/$pkgname-$pkgver/conf/nutcracker.root.yml \

The above line was wrapped.

...

> +md5sums="6b27455285f81e4335d00983076cf4b8 twemproxy-0.4.1.tar.gz
> +531b2ded35c9f9e3c53388ceb9da9e9d nutcracker.initd
> +5fcf33052bb7ddd286e58fcdef5335db nutcracker.confd
> +521837066110c2d0248c11620bf66e15 use-system-libyaml.patch"
> +sha256sums="00c2940f91947bea9457a348316aac1aa1d4e757238aafbefc9d51057da8ede0
> twemproxy-0.4.1.tar.gz
> +f6531c2bbb085e70e4de4b51a01e4b2a6fe6cec41ba4924cc7ac56d51393fdfd
> nutcracker.initd
> +ff28c0ffb1aa82e7bcd19c79f76cdb05641b4181f6668349fe9ed87044ce0d3e
> nutcracker.confd
> +718fe0cf3a48f51f5b8a2b6ef8120068b1604c7588b33e5db27de8301e77fdf4
> use-system-libyaml.patch"

The above lines was also wrapped.
 
...

> +--- twemproxy-0.4.1/src/Makefile.am
> ++++ twemproxy/src/twemproxy-0.4.1/src/Makefile.am
> +_at_@ -21,7 +21,7 @@
> + AM_CFLAGS += -Wstrict-prototypes -Wmissing-prototypes
> -Wredundant-decls -Wmissing-declarations

Above line was wrapped.

I manually unwrapped the lines but ended up with checksum error so I
either did a mistake or you forgot to abuild checksum or you have
unintended (or untested) changes in there some place.

Could you please use git send-email, or maybe do a github pull request?
https://github.com/alpinelinux/aports

-nc


---
Unsubscribe:  alpine-aports+unsubscribe_at_lists.alpinelinux.org
Help:         alpine-aports+help_at_lists.alpinelinux.org
---
Received on Thu Oct 22 2015 - 08:46:11 GMT