Mail archive
alpine-aports

Re: [alpine-aports] [PATCH] main/mariadb: upgrade to stable 10.1.8

From: Natanael Copa <ncopa_at_alpinelinux.org>
Date: Tue, 15 Dec 2015 09:34:18 +0100

Valery,

I have a question on a change that was not clearly explained in the
commit message.

On Mon, 19 Oct 2015 03:05:09 +0300
Valery Kartel <valery.kartel_at_gmail.com> wrote:

> ---
> main/mariadb/APKBUILD | 19 +++++++-------
> main/mariadb/mariadb.initd | 63 +++++++++++++---------------------------------
> 2 files changed, 27 insertions(+), 55 deletions(-)
>
> diff --git a/main/mariadb/APKBUILD b/main/mariadb/APKBUILD
> index 67c6239..7015b78 100644
> --- a/main/mariadb/APKBUILD
> +++ b/main/mariadb/APKBUILD
> _at_@ -3,8 +3,8 @@
> # Maintainer: Natanael Copa <ncopa_at_alpinelinux.org>
>
> pkgname=mariadb
> -pkgver=10.0.21
> -pkgrel=2
> +pkgver=10.1.8
> +pkgrel=0
> pkgdesc="A fast SQL database server"
> url="http://www.mariadb.org"
> pkgusers="mysql"

...

> diff --git a/main/mariadb/mariadb.initd b/main/mariadb/mariadb.initd
> index 8409bad..cb2a388 100644
> --- a/main/mariadb/mariadb.initd
> +++ b/main/mariadb/mariadb.initd
> _at_@ -1,15 +1,19 @@
> #!/sbin/openrc-run
> -# Copyright 1999-2004 Gentoo Foundation
> -# Distributed under the terms of the GNU General Public License v2
> -# $Header: /var/cvsroot/gentoo-x86/dev-db/mysql/files/mysql.init,v 1.7 2004/07/14 21:41:15 agriffis Exp $
>
> +getconf() {
> + v=$(my_print_defaults --mysqld | grep ^--$1)
> + [ -z $v ] && echo $2 || echo ${v#*=}
> +}
> +
> +retry="60"
> +pidfile=$(getconf pid-file "/run/mysqld/mysqld.pid")
> extra_stopped_commands="setup"
> -pidfile=/var/run/mysqld/mysqld.pid
> +command="/usr/bin/mysqld_safe"
> +command_args="--pid-file=$pidfile --syslog --nowatch"
>
> depend() {
> - need net
> - after firewall
> - use dns
> + use net
> + need localmount
> }

Why do we accept that mariadb may be started before the firewall? Isn't
that a potensial risk? What was the reason for this change?

Why do we remove the 'use dns'? Did it create problems? Did you
investigate why it was added in first place?

-nc


---
Unsubscribe:  alpine-aports+unsubscribe_at_lists.alpinelinux.org
Help:         alpine-aports+help_at_lists.alpinelinux.org
---
Received on Tue Dec 15 2015 - 09:34:18 GMT