Mail archive
alpine-aports

Re: [alpine-aports] [PATCH] main/alpine-conf: fix fs-related packages loading, load lvm2 only if _lvm install, remove bashisms, remove installing sfdisk to destination system

From: Natanael Copa <ncopa_at_alpinelinux.org>
Date: Thu, 17 Dec 2015 09:43:58 +0100

On Tue, 15 Dec 2015 15:06:54 +0200
Valery Kartel <valery.kartel_at_gmail.com> wrote:

> ---
> .../0003-setup-disk-fix-package-loading.patch | 51 ++++++++++++++++++++++
> main/alpine-conf/APKBUILD | 12 +++--
> 2 files changed, 59 insertions(+), 4 deletions(-)
> create mode 100644 main/alpine-conf/0003-setup-disk-fix-package-loading.patch

I have already pushed a tested variant of most of your fixes.
 
> diff --git a/main/alpine-conf/0003-setup-disk-fix-package-loading.patch b/main/alpine-conf/0003-setup-disk-fix-package-loading.patch
> new file mode 100644
> index 0000000..f79f9cc
> --- /dev/null
> +++ b/main/alpine-conf/0003-setup-disk-fix-package-loading.patch
> _at_@ -0,0 +1,51 @@
> +--- old/setup-disk.in
> ++++ new/setup-disk.in
> +_at_@ -323,7 +323,7 @@
> + cp /etc/apk/keys/* "$mnt"/etc/apk/keys/
> +
> + local apkflags="--initdb --quiet --progress --update-cache --clean-protected"
> +- local pkgs=$(cat "$mnt"/etc/apk/world "$mnt"/var/lib/apk/world 2>/dev/null)
> ++ local pkgs=$(grep -v sfdisk "$mnt"/etc/apk/world "$mnt"/var/lib/apk/world 2>/dev/null)
> + pkgs="$pkgs acct linux-$KERNEL_FLAVOR alpine-base"
> + if [ "$(rc --sys)" = "XEN0" ]; then
> + pkgs="$pkgs xen-hypervisor"

I don't you think you tested it because the above change will break the install.

I kind of expect patches to be tested and working before they are posted.

-nc


---
Unsubscribe:  alpine-aports+unsubscribe_at_lists.alpinelinux.org
Help:         alpine-aports+help_at_lists.alpinelinux.org
---
Received on Thu Dec 17 2015 - 09:43:58 GMT