[alpine-aports] Please *don't* drop prepare!
I noticed this recent commit:
>Author: Sören Tempel <email hidden>
>Date: Sun Jan 31 13:30:14 2016 +0100
> testing/noice: upgrade to 0.4
> diff --git a/testing/noice/APKBUILD b/testing/noice/APKBUILD
> index c2e2eed..77a7f0b 100644
>- local i
>- cd "$_builddir"
>- for i in $source; do
>- case $i in
>- *.patch) msg $i; patch -p1 -i "$srcdir"/$i || return 1;;
DON'T DO THAT!
This makes it needlessly hard to add patches: the moment someone wants to
fix a problem, this bites them because they'll try adding a patch,
build, and wonder "Why on earth am I seeing the problem I just fixed?"
I just ran into this with bridge-utils.
Is there a reason that this couldn't be moved to abuild?
I know that bash uses -p0 patches, which wouldn't work with this.
But other than that, it seems to be a universal constant.
Received on Sun Jan 31 2016 - 18:09:59 GMT