Mail archive
alpine-aports

Re: [alpine-aports] [PATCH 2/3] newapkbuild: remove default prepare()

From: Olivier Mauras <olivier_at_mauras.ch>
Date: Tue, 2 Feb 2016 06:50:25 +0100

On Mon, 1 Feb 2016 17:32:28 -0500
Muh Muhten <muh.muhten_at_gmail.com> wrote:

> Do not add prepare() to new APKBUILDs in the future, as this
> functionality is superseded by the addition of the default prepare
> patcher in abuild.
> ---
> newapkbuild.in | 15 ---------------
> 1 file changed, 15 deletions(-)
>
> diff --git a/newapkbuild.in b/newapkbuild.in
> index a47dcae..64b726b 100644
> --- a/newapkbuild.in
> +++ b/newapkbuild.in
> _at_@ -224,21 +224,6 @@ __EOF__
> fi
> fi
>
> -
> - # Create the prepare() template
> - cat >>APKBUILD<<__EOF__
> -prepare() {
> - local i
> - cd "\$_builddir"
> - for i in \$source; do
> - case \$i in
> - *.patch) msg \$i; patch -p1 -i "\$srcdir"/\$i || return 1;;
> - esac
> - done
> -}
> -
> -__EOF__
> -
> # Create build() function
> cat >>APKBUILD<<__EOF__
> build() {
> --
> 2.5.4 (Apple Git-61)
>
>
>
> ---
> Unsubscribe: alpine-aports+unsubscribe_at_lists.alpinelinux.org
> Help: alpine-aports+help_at_lists.alpinelinux.org
> ---

Hello,

How does that behave if one adds prepare() back in the APKBUILD? prepare() can be used for other things than just patches.

Regards,
Olivier




---
Unsubscribe:  alpine-aports+unsubscribe_at_lists.alpinelinux.org
Help:         alpine-aports+help_at_lists.alpinelinux.org
---
Received on Tue Feb 02 2016 - 06:50:25 GMT