Mail archive
alpine-aports

Re: [alpine-aports] [PATCH] main/dovecot: split some plugins to subpackages

From: Valery Kartel <valery.kartel_at_gmail.com>
Date: Mon, 22 Feb 2016 01:45:58 +0200

2016-02-20 12:02 GMT+02:00 Natanael Copa <ncopa_at_alpinelinux.org>:

> On Thu, 10 Dec 2015 01:44:14 +0200
> Valery Kartel <valery.kartel_at_gmail.com> wrote:
>
> > -acl: plugin for acl-s with related configs
> > -quota: quota plugin with related configs
> > -trash: trash for quota plugin with related configs. has dovecot-quota
> as dependency
> > -stats: Statistics plugin with related configs
> > -zlib: maildir compression plugin with related configs
> >
> > -expire: message expire plugin with no configs
> > -snarf: move mails from a "snarf mailbox" to user's real INBOX plugin
> with no configs
> > -listescape: Listescape plugin with no configs
> > -mail-filter: mail filter plugin with no configs
> > -fts: full text search plugin with no configs
>
> Hi sorry for late response on this patch. It didn't work and I have not
> had so much extrea time lately.
>

Hi,
This patch has not been claimed for a long time and I forgot about it for a
while.

> + $pkgname-trash $pkgname-zlib $pkgname-stats $pkgname-expire
> + $pkgname-mail-filter:filter $pkgname-listescape $pkgname-snarf
> + $pkgname-fts"
> "


You have an extra " in there. Abuild will not even parse this APKBUILDm
> which means that you have not tested if it even builds.
>
> I check it twice and found that I was not sent it from the main folder
with 'ready to go' patches but from a testing one where I constantly change
something.
It's really my mistake.

...
>
> > diff --git a/main/dovecot/dovecot-trash.conf.ext
> b/main/dovecot/dovecot-trash.conf.ext
> > new file mode 100644
> > index 0000000..4689935
> > --- /dev/null
> > +++ b/main/dovecot/dovecot-trash.conf.ext
> > _at__at_ -0,0 +1,8 @@
> > +# Spam mailbox is emptied before Trash
> > +1 Spam
> > +# Trash mailbox is emptied before Sent
> > +2 Trash
> > +# If both Sent and "Sent Messages" mailboxes exist, the next oldest
> message
> > +# to be deleted is looked up from both of the mailboxes.
> > +3 Sent
> > +3 Sent Messages
>
> I know for sure that you didn't even try build the APKBUILD. What
> should I think about the config changes? I wonder if you tested it or
> not.
>

My criteria for sending the changes, it is at least a successful compilation
.

>
> > diff --git a/main/dovecot/dovecot.initd b/main/dovecot/dovecot.initd
> > index 880a39f..ca6852f 100644
> > --- a/main/dovecot/dovecot.initd
> > +++ b/main/dovecot/dovecot.initd
> > _at__at_ -31,8 +31,7 @@ checkconfig() {
> > fi
> > DOVECOT_BASEDIR=${DOVECOT_BASEDIR:-/run/dovecot}
> > DOVECOT_PIDFILE=${DOVECOT_BASEDIR}/master.pid
> > - checkpath --directory --owner dovecot:dovecot --mode 0755 \
> > - ${DOVECOT_BASEDIR}
> > + checkpath --directory ${DOVECOT_BASEDIR}
> > }
>
> The commit message give no hint on why this change was necessary or
> that it actually happened. If I would have just applied it (and if it
> would have compiled) and I would have pushed it, the I would have been
> pushing code changes that I was not aware of had happened.
>

It's a last minute change and as I wrote before - it's a testing variant
and was not supposed to be sent.

But this change I can describe: We have a world-readable directory and the
master process runs from root. So it's a kind of overhead to change owner
and mode for /run/dovecot. All runtime sockets are created with owner of
child process and their permissions are setted-up in configs.
So, I just remove unnecessary startup overhead.

What do you think about sneaking in changes like this? Will my trust
> improve or decrease?
>
> What will I think when I see future patches?
>

It's my fault, and I acknowledge it, so you decide.


> I think the general idea is good, splitting up dovecot plugins in
> subpackages is good. Shipping a working config is good too.
>
> But I cannot commit this.
>
> Sorry.
>
> Never mind. In any case I'll remade it and send new version, because this
one has long been obsolete.


> -nc
>

-vaka



---
Unsubscribe:  alpine-aports+unsubscribe_at_lists.alpinelinux.org
Help:         alpine-aports+help_at_lists.alpinelinux.org
---
Received on Mon Feb 22 2016 - 01:45:58 GMT