Mail archive
alpine-aports

Re: [alpine-aports] [PATCH] main/rtorrent: Add libxml2-dev to ensure xmlrpc/scgi support

From: Natanael Copa <ncopa_at_alpinelinux.org>
Date: Thu, 25 Feb 2016 10:21:25 +0100

On Wed, 24 Feb 2016 18:49:36 -0800
Isaac Dunham <ibid.ag_at_gmail.com> wrote:

> On Wed, Feb 24, 2016 at 07:38:26AM +0000, Hervé Rousseau wrote:
> > (with correct commit msg/subject it's always better)
> >
> > APKBUILD specifies --with-xmlrpc-c but support isn't enabled because libxm2-dev is missing.
> > ./configure returns this:
> > checking for XMLRPC-C... /usr/bin/xmlrpc-c-config: line 66: xml2-config: not found
> > /usr/bin/xmlrpc-c-config: line 66: xml2-config: not found
>
> I see two issues with this patch:
> - you need to bump pkgrel to trigger a rebuild
>
> - that error means that the xmlrpc-c-config script is missing a dependency
> that it should have.
>
> In other words, xmlrpc-c-dev ideally should depend on libxml2-dev, because
> it's not possible to use it without libxml2-dev.
>
> Of course, if you fix that, you'd still need to bump rtorrent to pick up
> the fix (and possibly more packages).

I agree with Dunham on all those.

I'd also like commit message reformatted (wrap words at 72 chars,
remove text that is not intended for the git history)

Thanks!

-nc


---
Unsubscribe:  alpine-aports+unsubscribe_at_lists.alpinelinux.org
Help:         alpine-aports+help_at_lists.alpinelinux.org
---
Received on Thu Feb 25 2016 - 10:21:25 GMT