Mail archive
alpine-aports

Re: [alpine-aports] [PATCH 1/6] testing/gdal: new aport

From: Sören Tempel <soeren_at_soeren-tempel.net>
Date: Sat, 5 Mar 2016 20:31:51 +0100

On 28.02.16, Trevor R.H. Clarke wrote:
> +depends_py="gdal python"

I have never heard of this variable. I don't think that abuild actually
uses this for anything…

On 28.02.16, Trevor R.H. Clarke wrote:
> +prepare() {
> + local i
> + cd "$_builddir"
> + for i in $source; do
> + case $i in
> + *.patch) msg $i; patch -p1 -i "$srcdir"/$i || return 1;;
> + esac
> + done
> +}

As of abuild 2.26.0 this is the default prepare function you no longer
need to supply it explicitly.

On 28.02.16, Trevor R.H. Clarke wrote:
> +build() {
> + cd "$_builddir"
> + ./configure --prefix=/usr
> + make -j8 || return 1
> +}

You don't want to explicitly pass -j8 to make here. Usually the amount
of makejobs to use is set using the MAKEFLAGS environment variable in
abuild.conf. Generally speaking -j is only set explicitly when the
package doesn't support parallel builds.

On 28.02.16, Trevor R.H. Clarke wrote:
> +py() {
> + pkgdesc="$pkgname python bindings"
> + mkdir -p "$subpkgdir"/usr/lib
> + mkdir -p "$subpkgdir"/usr/bin
> + cd "$_builddir"/swig/python
> + python setup.py build || return 1
> + python setup.py install --prefix=/usr --root="$subpkgdir"
> + chmod a+x scripts/*
> + cp scripts/* $subpkgdir/usr/bin/
> +}

This doesn't seem to be indented correctly and also contains
whitespaces. Please indent everything with tabs and remove the
whitespaces. Also it would probably be easier to install the scripts
using install(1) and pass -m755 but that's just a minor thing.

On 28.02.16, Trevor R.H. Clarke wrote:
> +package() {
> + cd "$_builddir"
> + install -Dm644 LICENSE.TXT "$pkgdir"/usr/share/licenses/$pkgname/LICENSE.TXT
> + make DESTDIR="${pkgdir}" install || return 1
> +}

Again this contains whitespaces and the indention seems to be wrong.

Sören.


---
Unsubscribe:  alpine-aports+unsubscribe_at_lists.alpinelinux.org
Help:         alpine-aports+help_at_lists.alpinelinux.org
---
Received on Sat Mar 05 2016 - 20:31:51 GMT