Mail archive
alpine-aports

Re: [alpine-aports] [PATCH v2 1/2] testing/nldev: new aport

From: Timo Teras <timo.teras_at_iki.fi>
Date: Tue, 8 Mar 2016 09:05:29 +0200

Looks mostly good. But...

On Mon, 29 Feb 2016 22:58:39 +0100
Sören Tempel <soeren+git_at_soeren-tempel.net> wrote:

> +start_pre() {
> + if [ -e /proc/self/fd ]; then
> + rm -f /dev/fd 2>/dev/null
> + ln -sf /proc/self/fd /dev/fd
> + fi
> +}

This looks risky. When restarting this may make /dev/fd unavailable
temporarily and break quite a bit of stuff.

Why is this here in the first place? If necessary, perhaps use readlink
to verify if it needs recreation? And is the 'rm' needed, ln -snf
should be able to replace any entry.

Thanks,
Timo




---
Unsubscribe:  alpine-aports+unsubscribe_at_lists.alpinelinux.org
Help:         alpine-aports+help_at_lists.alpinelinux.org
---
Received on Tue Mar 08 2016 - 09:05:29 GMT