Mail archive
alpine-aports

Re: [alpine-aports] [PATCH v2 1/2] testing/nldev: new aport

From: Muh Muhten <muh.muhten_at_gmail.com>
Date: Wed, 9 Mar 2016 01:43:17 -0500

ln -snf isn't atomic either, but istm that if /dev/fd is pointed
somewhere else, surely this is not the right place to fix it?

On 2016-03-08 2:05 AM, Timo Teras wrote:
> Looks mostly good. But...
>
> On Mon, 29 Feb 2016 22:58:39 +0100
> Sören Tempel <soeren+git_at_soeren-tempel.net> wrote:
>
>> +start_pre() {
>> + if [ -e /proc/self/fd ]; then
>> + rm -f /dev/fd 2>/dev/null
>> + ln -sf /proc/self/fd /dev/fd
>> + fi
>> +}
>
> This looks risky. When restarting this may make /dev/fd unavailable
> temporarily and break quite a bit of stuff.
>
> Why is this here in the first place? If necessary, perhaps use readlink
> to verify if it needs recreation? And is the 'rm' needed, ln -snf
> should be able to replace any entry.
>
> Thanks,
> Timo
>
>
>
>
> ---
> Unsubscribe: alpine-aports+unsubscribe_at_lists.alpinelinux.org
> Help: alpine-aports+help_at_lists.alpinelinux.org
> ---
>


---
Unsubscribe:  alpine-aports+unsubscribe_at_lists.alpinelinux.org
Help:         alpine-aports+help_at_lists.alpinelinux.org
---
Received on Wed Mar 09 2016 - 01:43:17 GMT