Mail archive
alpine-aports

Re: [alpine-aports] [PATCH 2/3] testing/ghc-bootstrap new aport

From: Sören Tempel <soeren_at_soeren-tempel.net>
Date: Wed, 9 Mar 2016 22:30:25 +0100

Didn't have the time to take a closer look at this or to actually test
this so far but on a quick first look it looks good so far, only noticed
the following two things:

On 01.03.16, Mitch Tishmack wrote:
> +depends="bash libffi musl zlib gcc binutils-gold ghc-llvm-3.5"

Actually you don't need to explicitly depend on musl and gcc since those
two are part of build-base.

On 01.03.16, Mitch Tishmack wrote:
> +$(GHC_BS):
> + curl -LO https://downloads.haskell.org/~ghc/$(GHC_VERSION)/$_at_
> +
> +$(GHC_SRC):
> + curl -LO https://www.haskell.org/ghc/dist/$(GHC_VERSION)/$_at_
> +
> +$(CABAL_BS):
> + curl -LO https://www.haskell.org/cabal/release/cabal-install-$(CABAL_VERSION)/$_at_
> +
> +$(LLVM_BS):
> + curl -LO http://llvm.org/releases/$(LLVM_VERSION)/$_at_
> +
> +$(POLLY_BS):
> + curl -LO http://llvm.org/releases/$(LLVM_VERSION)/$_at_

You might want to fetch those by adding them to the source variable in
the APKBUILD otherwise their checksum/integrity is not verified
automatically.

Furthermore I doubt that the Makefile is really needed you could also
add a custom function to your APKBUILD instead even though I am not
quite sure if that would be any cleaner.

Sören.


---
Unsubscribe:  alpine-aports+unsubscribe_at_lists.alpinelinux.org
Help:         alpine-aports+help_at_lists.alpinelinux.org
---
Received on Wed Mar 09 2016 - 22:30:25 GMT