Mail archive
alpine-aports

Re: [alpine-aports] [PATCH v2] testing/php7: add iconv subpkg

From: Timo Teras <timo.teras_at_iki.fi>
Date: Mon, 4 Apr 2016 09:14:55 +0300

On Sun, 3 Apr 2016 17:23:05 +0000
Stuart Cardall <developer_at_it-offshore.co.uk> wrote:

> ---
> Changes v1 -> v2:
> - pkgrel bumped correctly
> = this should apply cleanly after Valery's 7.0.5 patch sent today
>
> testing/php7/APKBUILD | 27 +++++++++++++++++----------
> testing/php7/libintl-iconv.patch | 10 ++++++++++
> 2 files changed, 27 insertions(+), 10 deletions(-)
> create mode 100644 testing/php7/libintl-iconv.patch
>
> _at_@ -400,7 +404,7 @@ xsl() { _mv_ext xsl $pkgname-dom; }
> zip() { _mv_ext zip; }
> zlib() { _mv_ext zlib; }
>
> -md5sums="0171201350941327399a5c3e678a86e5 php-7.0.4.tar.bz2
> +md5sums="b15e6836babcbf0aa446678ee38f896b php-7.0.5.tar.bz2
> a340f27e83ed4482d2fbb98658ef71cb php7-fpm.initd
> 25bde13e7894c2930d97fad68d5dd3b3 php7-fpm.logrotate
> 47be6cd1ed92f21579e15bf2003a709f php7-module.conf

These checksum updates are incorrect and do not apply.

> _at_@ -0,0 +1,10 @@ +--- php-7.0.4/ext/standard/string.c ++++
> php-7.0.4/ext/standard/string.c.new +_at_@ -23,6 +23,7 @@
> + /* Synced with php 3.0 revision 1.193 1999-06-16 [ssb] */
> +
> + #include <stdio.h>
> ++#include <libintl.h>
> + #include "php.h"
> + #include "php_rand.h"
> + #include "php_string.h"

Is this patch really needed?

We had few issues with the gettext-dev package, but it should be finally
fixed now (there turned out to be one busybox ash bug that broke one of
the configure tests in gettext).

I see that main/php enables iconv similary, and does not need a patch
like this.

Thanks,
Timo


---
Unsubscribe:  alpine-aports+unsubscribe_at_lists.alpinelinux.org
Help:         alpine-aports+help_at_lists.alpinelinux.org
---
Received on Mon Apr 04 2016 - 09:14:55 GMT