Mail archive
alpine-aports

[alpine-aports] [PATCH 0/7] Pre-upgrade/pre-install addgroup/adduser cleanings

From: Przemyslaw Pawelczyk <przemoc_at_zoho.com>
Date: Sat, 23 Apr 2016 13:13:34 +0200

This is a follow-up patch series to the alpine-devel ML thread titled:

    UID+GID inconsistency for installed services

Initially it was meant to only add -S option to scripts where group or
user is created, but it needed some preparatory actions and after
finally adding the options I couldn't resist temptation to slightly
reformat scripts, i.e. to make them more consistent and easier to update
(manually or automatically) in future.

Beside -S option (and additionally -g option in case of adduser) there
was no change in options provided to addgroup or adduser. This patch
series was not intended to deeply review how groups/users are created in
each package, and whether options other than -S (and -g for adduser) are
lacking. There are too many packages and package-specific knowledge is
required to do so properly. Package maintainers are still encouraged to
give second thoughts on pre-install and pre-upgrade scripts to improve
them further, but such changes rather shouldn't be part of this set.

(I lied above, because there was one change in options provided to
adduser for squid package, which was required to fix wrong home dir.)

Please review these patches thoroughly to check for mistakes (unwanted
changes). They touch a lot of files, so despite numerous self-reviews,
I could overlook something.

These patches do not bump pkgrel number, because they work on whole tree
and changes were splitted across these patches. I also prepared patches
bumping pkgrel, but there are so many of them, that lead me to avoiding
sending them to alpine-aports ML, yet providing them via other means:

 http://paste.przemoc.net/alpine/20160423-addgroupuser-bump-pkgrel.mbox.gz

Patches from mbox bumping pkgrel have to be applied AFTER this patch
set. All packages that had changes in scripts, even if insubstantial,
are covered by them. If you don't want to bump pkgrel of unmaintained
packages, please ignore/drop last 4 patches from mbox.


Are pre-upgrade/pre-install scripts using addgroup/adduser fully
consistent after applying this patch series?

Surely not. There are things like line-wrapping for instance that are
sometimes present and sometimes not, but I wanted to preserve some
original conventions seen in scripts and leave further refining them for
future. It's kind of milestone and I had to stop at some point to not
delay this patch set any further, especially not beyond upcoming AL
3.4.0. Sorry for disappointing those wishing for getting perfectly
consistent scripts in one go.


Przemyslaw Pawelczyk (7):
  Reorder options passed to addgroup in scripts: make -S first.
  Reorder options passed to adduser in scripts: make -S first.
  Add lacking -S option (system) to adduser/addgroup in scripts.
  Add -g option (GECOS/comment) to adduser in scripts.
  Improve consistency of scripts using adduser/addgroup.
  main/squid: Fix squid's home directory specification.
  Reorder arguments passed to addgroup/adduser in scripts.

 community/caddy/caddy.pre-install | 4 +++-
 community/davfs2/davfs2.pre-install | 5 ++---
 community/docker-registry/docker-registry.pre-install | 3 ++-
 community/docker/docker.pre-install | 5 ++---
 community/domoticz/domoticz.pre-install | 4 +++-
 community/icinga2/icinga2.pre-install | 10 ++++++----
 community/minetest/minetest-server.pre-install | 4 +++-
 community/oscam/oscam.pre-install | 4 +++-
 community/redmine/redmine.pre-install | 4 ++--
 community/seafile/seafile-server.pre-install | 3 ++-
 community/smstools/smstools.pre-install | 8 +++++---
 community/sniproxy/sniproxy.pre-install | 4 +++-
 community/sword/sword.pre-install | 5 ++++-
 community/syncthing/syncthing.pre-install | 4 +++-
 community/tvheadend/tvheadend.pre-install | 4 +++-
 main/abuild/abuild.pre-install | 5 ++---
 main/alpine-baselayout/alpine-baselayout.pre-install | 5 ++---
 main/alpine-baselayout/alpine-baselayout.pre-upgrade | 6 +++---
 main/amavisd-new/amavisd-new.pre-install | 6 +++---
 main/apache2/apache2.pre-install | 6 ++++--
 main/apache2/apache2.pre-upgrade | 3 ++-
 main/aports-build/aports-build.pre-install | 3 ++-
 main/arpwatch/arpwatch.pre-install | 5 +++--
 main/asterisk/asterisk.pre-install | 3 ++-
 main/asterisk/asterisk.pre-upgrade | 3 ++-
 main/atheme-iris/atheme-iris.pre-install | 5 +++--
 main/avahi/avahi.pre-install | 5 ++---
 main/backuppc/backuppc.pre-install | 6 ++++--
 main/bacula-client/bacula-client.pre-install | 4 +++-
 main/bacula/bacula.pre-install | 4 +++-
 main/bind/bind.pre-install | 4 ++--
 main/charybdis/charybdis.pre-install | 4 +++-
 main/chrony/chrony.pre-install | 5 +++--
 main/clamav/clamav-daemon.pre-install | 3 ++-
 main/clamav/clamav-db.pre-install | 3 ++-
 main/clamav/freshclam.pre-install | 3 ++-
 main/clamsmtp/clamsmtp.pre-install | 3 ++-
 main/clamsmtp/clamsmtp.pre-upgrade | 3 ++-
 main/coova-chilli/coova-chilli.pre-install | 5 +++--
 main/cups/cups.pre-install | 3 ++-
 main/cvechecker/cvechecker.pre-install | 7 +++++--
 main/dansguardian/dansguardian.pre-install | 4 +++-
 main/darkhttpd/darkhttpd.pre-install | 6 +++---
 main/dbus/dbus.pre-install | 3 ++-
 main/dhcp/dhcp.pre-install | 4 ++--
 main/distcc/distcc.pre-install | 3 ++-
 main/djbdns/dnscache.pre-install | 4 ++--
 main/djbdns/tinydns.pre-install | 4 ++--
 main/dnsmasq/dnsmasq.pre-install | 5 +++--
 main/dovecot/dovecot.pre-install | 5 +++--
 main/ez-ipupdate/ez-ipupdate.pre-install | 4 ++--
 main/fetchmail/fetchmail.pre-install | 3 ++-
 main/freeradius/freeradius.pre-install | 6 +++---
 main/freeswitch/freeswitch.pre-install | 2 +-
 main/gdnsd/gdnsd.pre-install | 5 +++--
 main/gitolite/gitolite.pre-install | 4 +++-
 main/gnats/gnats.pre-install | 3 ++-
 main/gross/gross.pre-install | 4 +++-
 main/haproxy/haproxy.pre-install | 7 ++++---
 main/haproxy/haproxy.pre-upgrade | 7 ++++---
 main/icecast/icecast.pre-install | 2 +-
 main/ircservices/ircservices.pre-install | 4 ++--
 main/kamailio/kamailio.pre-install | 4 ++--
 main/libgphoto2/libgphoto2.pre-install | 5 ++---
 main/libvirt/libvirt.post-install | 4 +++-
 main/lighttpd/lighttpd.pre-install | 4 ++--
 main/logcheck/logcheck.pre-install | 5 +++--
 main/mariadb/mariadb.pre-install | 4 ++--
 main/memcached/memcached.pre-install | 4 ++--
 main/mini_httpd/mini_httpd.pre-install | 6 +++---
 main/minidlna/minidlna.pre-install | 5 +++--
 main/mlmmj/mlmmj.pre-install | 5 +++--
 main/mosquitto/mosquitto.pre-install | 3 ++-
 main/mpd/mpd.pre-install | 4 +++-
 main/mumble/murmur.pre-install | 6 ++++--
 main/nagios/nagios.pre-install | 3 ++-
 main/nginx-initscripts/nginx-initscripts.pre-install | 6 +++---
 main/nginx/nginx-common.pre-install | 2 +-
 main/ngircd/ngircd.pre-install | 3 ++-
 main/nrpe/nrpe.pre-install | 5 +++--
 main/nsd/nsd.pre-install | 4 +++-
 main/nss-pam-ldapd/nss-pam-ldapd.pre-install | 5 +++--
 main/ntop/ntop.pre-install | 4 +++-
 main/open-vm-tools/open-vm-tools.pre-install | 5 +++--
 main/openldap/openldap.pre-install | 4 ++--
 main/openntpd/openntpd.pre-install | 2 +-
 main/opensmtpd/opensmtpd.pre-install | 6 ++----
 main/opentracker/opentracker.pre-install | 4 ++--
 main/openvpn/openvpn.pre-install | 3 ++-
 main/pcsc-lite/pcsc-lite.pre-install | 5 +++--
 main/pdnsd/pdnsd.pre-install | 3 ++-
 main/perdition/perdition.pre-install | 2 +-
 main/postfix/postfix.pre-install | 5 ++---
 main/postgrey/postgrey.pre-install | 4 ++--
 main/privoxy/privoxy.pre-install | 6 +++---
 main/qemu/qemu.pre-install | 4 +++-
 main/quagga-nhrp/quagga-nhrp.pre-install | 4 ++--
 main/quagga/quagga.pre-install | 4 ++--
 main/quassel/quassel-core.pre-install | 2 +-
 main/radvd/radvd.pre-install | 4 +++-
 main/redis/redis.pre-install | 5 +++--
 main/rpcbind/rpcbind.pre-install | 3 ++-
 main/rt4/rt4.pre-install | 3 ++-
 main/rtnppd/rtnppd.pre-install | 3 ++-
 main/rtpproxy/rtpproxy.pre-install | 3 ++-
 main/samba/winbind.pre-install | 2 +-
 main/sems/sems.pre-install | 8 ++------
 main/sircbot/sircbot.pre-install | 5 +++--
 main/smokeping/smokeping.pre-install | 5 +++--
 main/snmptt/snmptt.pre-install | 4 +++-
 main/snort/snort.pre-install | 3 ++-
 main/squark/squark.post-install | 5 ++++-
 main/squid/squid.pre-install | 7 ++++---
 main/squid/squid.pre-upgrade | 7 ++++---
 main/strongswan/strongswan.pre-install | 8 ++------
 main/subversion/subversion.pre-install | 6 +++---
 main/tinyproxy/tinyproxy.pre-install | 2 +-
 main/trac/trac.pre-install | 5 +++--
 main/transmission/transmission-daemon.pre-install | 2 +-
 main/umurmur/umurmur.post-install | 6 ++++--
 main/unbound/unbound.pre-install | 3 ++-
 main/uvncrepeater/uvncrepeater.pre-install | 4 ++--
 main/varnish/varnish.pre-install | 3 ++-
 main/vde2/vde2.pre-install | 2 +-
 main/vlc/vlc-daemon.pre-install | 4 +++-
 main/vsftpd/vsftpd.pre-install | 8 +++++---
 main/ympd/ympd.pre-install | 4 +++-
 main/zabbix/zabbix-agent.pre-install | 6 +++---
 main/zabbix/zabbix.pre-install | 3 ++-
 main/znc/znc.pre-install | 4 +++-
 testing/3proxy/3proxy.pre-install | 6 +++---
 testing/at/at.pre-install | 15 +++------------
 testing/bitcoin/bitcoin.pre-install | 5 +++--
 testing/buildbot-slave/buildbot-slave.pre-install | 5 +++--
 testing/buildbot/buildbot.pre-install | 5 +++--
 testing/clapf/clapf.pre-install | 4 +++-
 testing/cluster-glue/cluster-glue.pre-install | 9 +++++----
 testing/consul/consul.pre-install | 6 +++---
 testing/crtmpserver/crtmpserver.pre-install | 4 +++-
 testing/dante/dante-server.pre-install | 3 ++-
 .../darwin-streaming-server.post-install | 6 ++++--
 testing/dbmail/dbmail.pre-install | 4 ++--
 testing/dnscrypt-proxy/dnscrypt-proxy.pre-install | 4 +++-
 testing/drizzle/drizzle.post-install | 8 ++++++--
 testing/dspam/dspam.pre-install | 4 ++--
 testing/ejabberd/ejabberd.pre-install | 4 +++-
 testing/elasticsearch/elasticsearch.pre-install | 6 +++---
 testing/emby/emby.pre-install | 8 +++++---
 testing/exim/exim.pre-install | 2 +-
 testing/fcron/fcron.pre-install | 6 ++++--
 testing/gdnsd/gdnsd.pre-install | 5 +++--
 testing/gogs/gogs.pre-install | 6 ++++--
 testing/h2o/h2o.pre-install | 4 ++--
 testing/knot/knot.pre-install | 2 +-
 testing/lightdm/lightdm.pre-install | 4 +++-
 testing/lizardfs/lizardfs.pre-install | 3 ++-
 testing/logstash/logstash.pre-install | 4 ++--
 testing/lshell/lshell.pre-install | 4 +++-
 testing/lusca/lusca.pre-install | 7 ++++---
 testing/lusca/lusca.pre-upgrade | 7 ++++---
 testing/milter-greylist/milter-greylist.pre-install | 6 ++++--
 testing/mlocate/mlocate.pre-install | 2 ++
 testing/mongodb/mongodb.pre-install | 5 +++--
 testing/motion/motion.pre-install | 7 ++++---
 testing/munin/munin-node.pre-install | 4 ++--
 testing/namecoin/namecoin.pre-install | 5 +++--
 testing/nginx-naxsi/nginx-naxsi.pre-install | 6 +++---
 testing/ntopng/ntopng.pre-install | 4 +++-
 testing/nut/nut.pre-install | 1 +
 testing/opennebula/opennebula-node-kvm.pre-install | 7 ++++---
 testing/opennebula/opennebula.pre-install | 7 ++++---
 testing/opensips/opensips.pre-install | 2 +-
 testing/openxcap/openxcap.pre-install | 5 +++--
 testing/pdns/pdns.pre-install | 3 ++-
 testing/prosody/prosody.pre-install | 8 +++++---
 testing/qpage/qpage.pre-install | 4 +++-
 testing/quicktun/quicktun.pre-install | 7 ++++---
 testing/radicale/radicale.pre-install | 4 +++-
 testing/rancid/rancid.pre-install | 5 +++--
 testing/rmilter/rmilter.pre-install | 2 +-
 testing/rrdbot/rrdbot.pre-install | 2 +-
 testing/rspamd/rspamd.pre-install | 2 +-
 testing/rutorrent/rutorrent.pre-install | 5 +++--
 testing/sipwise-sems/sipwise-sems.pre-install | 8 ++------
 testing/socklog/socklog.post-install | 3 ++-
 testing/stunnel/stunnel.pre-install | 3 ++-
 testing/tengine/tengine.pre-install | 6 +++---
 testing/tengine/tengine.pre-upgrade | 6 +++---
 testing/thttpd/thttpd.pre-install | 8 +++++---
 testing/tor/tor.pre-install | 5 +++--
 testing/tvheadend-git/tvheadend-git.pre-install | 4 +++-
 testing/udevil/udevil.pre-install | 3 ++-
 testing/vault/vault.pre-install | 3 ++-
 testing/vnstat/vnstat.pre-install | 3 ++-
 testing/wt/wt.pre-install | 6 ++++--
 testing/x2goserver/x2goserver.pre-install | 6 ++++--
 testing/zabbix/zabbix-agent.pre-install | 7 ++++---
 testing/zabbix/zabbix.pre-install | 3 ++-
 unmaintained/apache-couchdb/apache-couchdb.post-install | 6 ++++--
 unmaintained/ejabberd-git/ejabberd-git.pre-install | 4 +++-
 unmaintained/kde-workspace/kde-workspace.pre-install | 4 +++-
 unmaintained/shadowircd/shadowircd.pre-install | 4 +++-
 202 files changed, 544 insertions(+), 374 deletions(-)

-- 
2.6.6
---
Unsubscribe:  alpine-aports+unsubscribe_at_lists.alpinelinux.org
Help:         alpine-aports+help_at_lists.alpinelinux.org
---
Received on Sat Apr 23 2016 - 13:13:34 GMT