Mail archive
alpine-aports

Re: [alpine-aports] [PATCH 0/7] Pre-upgrade/pre-install addgroup/adduser cleanings

From: Natanael Copa <ncopa_at_alpinelinux.org>
Date: Mon, 25 Apr 2016 09:24:29 +0200

On Sat, 23 Apr 2016 13:13:34 +0200
Przemyslaw Pawelczyk <przemoc_at_zoho.com> wrote:

> This is a follow-up patch series to the alpine-devel ML thread titled:
>
> UID+GID inconsistency for installed services

I have pushed them. Many thanks!

...

> These patches do not bump pkgrel number, because they work on whole tree
> and changes were splitted across these patches. I also prepared patches
> bumping pkgrel, but there are so many of them, that lead me to avoiding
> sending them to alpine-aports ML, yet providing them via other means:
>
> http://paste.przemoc.net/alpine/20160423-addgroupuser-bump-pkgrel.mbox.gz

I applied them and merged them into 3 bigger commits.

>
> Patches from mbox bumping pkgrel have to be applied AFTER this patch
> set. All packages that had changes in scripts, even if insubstantial,
> are covered by them.

> If you don't want to bump pkgrel of unmaintained
> packages, please ignore/drop last 4 patches from mbox.

Those are not needed so they were dropped.
 
> Are pre-upgrade/pre-install scripts using addgroup/adduser fully
> consistent after applying this patch series?
>
> Surely not. There are things like line-wrapping for instance that are
> sometimes present and sometimes not, but I wanted to preserve some
> original conventions seen in scripts and leave further refining them for
> future. It's kind of milestone and I had to stop at some point to not
> delay this patch set any further, especially not beyond upcoming AL
> 3.4.0. Sorry for disappointing those wishing for getting perfectly
> consistent scripts in one go.

I totally agree. Better do incremental improvements that actually gets
in than trying to engineer something so prefect that it never gets in.

This is a big step forward and I think the timing for the 3.4 release
was perfect. Right before I start up the v3.4 builders (well, I already
started armhf builder...)

I should also mention that there have been talking about add a feature
to apk to create users and groups. When that lands we will probably be
able to remove most of the pre-install scripts. Meanwhile, this is a
big improvement.

Again. Many thanks!

-nc


---
Unsubscribe:  alpine-aports+unsubscribe_at_lists.alpinelinux.org
Help:         alpine-aports+help_at_lists.alpinelinux.org
---
Received on Mon Apr 25 2016 - 09:24:29 GMT