Mail archive
alpine-aports

Re: [alpine-aports] [PATCH] community/cf-cli: new aport

From: Natanael Copa <ncopa_at_alpinelinux.org>
Date: Wed, 22 Jun 2016 00:09:53 +0200

On Thu, 12 May 2016 12:22:51 +0000
Thomas Boerger <thomas_at_webhippie.de> wrote:

> https://github.com/cloudfoundry/cli
> A CLI for Cloud Foundry written in Go
> ---
> community/cf-cli/APKBUILD | 67 +++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 67 insertions(+)
> create mode 100644 community/cf-cli/APKBUILD

Hi, thanks for the patch. It does not build for me.
 
> diff --git a/community/cf-cli/APKBUILD b/community/cf-cli/APKBUILD
> new file mode 100644
> index 0000000..b0b0e1d
> --- /dev/null
> +++ b/community/cf-cli/APKBUILD
> _at_@ -0,0 +1,67 @@
> +# Contributor: Thomas Boerger <thomas_at_webhippie.de>
> +# Maintainer: Thomas Boerger <thomas_at_webhippie.de>
> +pkgname=cf-cli

Can you please rename it to:

pkgname="cloudfoundry-cli"

> +pkgver=6.18.0
> +pkgrel=0
> +pkgdesc="A CLI for Cloud Foundry written in Go"
> +url="https://github.com/cloudfoundry/cli"
> +arch="all"
> +license="Apache 2.0"
> +depends=""
> +depends_dev=""
> +makedepends="$depends_dev go bash"
> +install=""
> +subpackages=""
> +source="http://dev.alpinelinux.org/archive/$pkgname/$pkgname-$pkgver.tar.gz"
> +
> +_disturl="dev.alpinelinux.org:/archive/$pkgname/"
> +_gourl="github.com/cloudfoundry/cli"
> +_builddir="$srcdir"/src/$_gourl

Can you please use the source tarball found on
https://github.com/cloudfoundry/cli/releases

Something like:

source="$pkgname-$pkgver.tar.gz::https://github.com/cloudfoundry/cli/archive/v$pkgver.tar.gz"


> +
> +prepare() {
> + local i
> + cd "$_builddir"
> + for i in $source; do
> + case $i in
> + *.patch) msg $i; patch -p1 -i "$srcdir"/$i || return 1;;
> + esac
> + done
> +}
> +
> +snapshot() {

Please remove the snapshot func and use source tarball from github.


> +
> +build() {
> + cd "$_builddir" || return 1
> + export GOPATH="$srcdir"
> + ./bin/build
> +}

Please be consistent with indentation. I know not everyone agrees on
how to indent things but it is best practices to use the indent style
of the project you contribute to.

Thanks!

-nc


---
Unsubscribe:  alpine-aports+unsubscribe_at_lists.alpinelinux.org
Help:         alpine-aports+help_at_lists.alpinelinux.org
---
Received on Wed Jun 22 2016 - 00:09:53 GMT