Mail archive
alpine-aports

Re: [alpine-aports] [PATCH] main/lddtree: Make lddtree canonicalize symlinks when resolving them.

From: Timo Teras <timo.teras_at_iki.fi>
Date: Fri, 4 Nov 2016 09:19:17 +0200

On Wed, 12 Oct 2016 01:47:01 +0200
Linus Swälas <linus.swalas_at_borderless.se> wrote:

> diff --git a/main/lddtree/0001-lddtree-canonicalize-symlinks.patch
> b/main/lddtree/0001-lddtree-canonicalize-symlinks.patch new file mode
> 100644 index 0000000..ea65434
> --- /dev/null
> +++ b/main/lddtree/0001-lddtree-canonicalize-symlinks.patch
> _at_@ -0,0 +1,11 @@
> +--- lddtree-1.25.orig/lddtree.sh 2016-10-10
> 03:28:25.941861438 +0200 ++++ lddtree-1.25/lddtree.sh
> 2016-10-10 03:29:03.838528005 +0200 +_at_@ -148,7 +148,7 @@
> + list_existing_file "${_resolv_links}"
> + cd "${_resolv_links%/*}"
> + while [ -L "$_resolv_links" ]; do
> +- _resolv_links=$(readlink "$_resolv_links")
> ++ _resolv_links=$(readlink -f "$_resolv_links")
> + case "$_resolv_links" in
> + /*) _resolv_links="${ROOT}${_resolv_links#/}"
> + cd "${_resolv_links%/*}"

Could you submit this as pull request to the upstream project first?
Would be nice to have in the commit message a description what this
fixes, or why this should be used.

Thanks.


---
Unsubscribe:  alpine-aports+unsubscribe_at_lists.alpinelinux.org
Help:         alpine-aports+help_at_lists.alpinelinux.org
---
Received on Fri Nov 04 2016 - 09:19:17 GMT