thank you for the updated patch.
On ven, 2017-01-06 at 18:10 -0600, Corey Oliver wrote:
> ---> Changes v1 -> v2:> - use the built-in abuild function default_prepare> > testing/node-sodium/APKBUILD | 48> +++++++++++++++++++++++++++++> testing/node-sodium/fix-gyp-binding.patch | 11 +++++++> testing/node-sodium/remove-preinstall.patch | 10 ++++++> 3 files changed, 69 insertions(+)> create mode 100644 testing/node-sodium/APKBUILD> create mode 100644 testing/node-sodium/fix-gyp-binding.patch> create mode 100644 testing/node-sodium/remove-preinstall.patch> > diff --git a/testing/node-sodium/APKBUILD b/testing/node-> sodium/APKBUILD> new file mode 100644> index 0000000..b96b409> --- /dev/null> +++ b/testing/node-sodium/APKBUILD> @@ -0,0 +1,48 @@> +# Contributor: Corey Oliver <coreyjonoliver@gmail.com>> +# Maintainer: Corey Oliver <coreyjonoliver@gmail.com>> +pkgname=node-sodium> +_pkgname=sodium> +pkgver=1.2.3> +pkgrel=0> +pkgdesc="Port of the lib sodium encryption library to Node.js"> +url="https://github.com/paixaop/node-sodium"> +arch="all"> +license="MIT"> +depends="nodejs libsodium=1.0.11-r0"
Libraries are automatically detect by abuild, so you don't need to
explicitly add them. So I committed your patch, with "depends" updated.
Sorry for missing this in the previous email.
Thanks!
-|_eo
On lun, 2017-01-09 at 09:06 +0100, Leonardo Arena wrote:
> thank you for the updated patch.> > On ven, 2017-01-06 at 18:10 -0600, Corey Oliver wrote:> > > > ---> > Changes v1 -> v2:> > - use the built-in abuild function default_prepare> >
Unfortunately build fails on armhf/aarch64 with:
> sodium@1.2.2 test /home/buildozer/aports/testing/node-
sodium/src/node-sodium-1.2.3
> make test
AES 256 gcm not supported by CPU
/home/buildozer/aports/testing/node-sodium/src/node-sodium-
1.2.3/test/test_aead_aes256gcm.js:3095
done();
^
I'm going to disable those builds until a fix is available.
Thanks!
-|_eo