Mail archive
alpine-aports

Re: [alpine-aports] [PATCH v2] main/nano: Ditch empty vars in APKBUILD. Change maintainer.

From: Przemysław Pawełczyk <przemoc_at_zoho.com>
Date: Wed, 18 Jan 2017 21:52:01 +0100

Hi!

 ---- On Wed, 18 Jan 2017 13:59:09 +0100 Leonardo Arena <rnalrd_at_gmail.com> wrote ----
> On sab, 2017-01-14 at 20:41 +0100, Przemyslaw Pawelczyk wrote:
> > Old alleged maintainer (Michael Zhou) made himself maintainer with
> > commit d2f2f034f33f4c6d8df8573da9455b475f6550f6, but he never touched
> > nano ever again. He has almost no trace of any activity in aports
> > repo
> > since 2011 (1 commit in 2016).
> >
> > Natanael Copa is the most active contributor, so hopefully he's not
> > against becoming maintainer of another package.
> > ---
> >
> > Łukasz Jendrysik was not aware of my nano upgrade in patchwork,
> > so he did PR in github and Jakub Jirutka applied it quickly then.
> > Here is the remaining part of my original patch.
> >
> >
> > main/nano/APKBUILD | 5 ++---
> > 1 file changed, 2 insertions(+), 3 deletions(-)
> >
> > diff --git a/main/nano/APKBUILD b/main/nano/APKBUILD
> > index 3bbd36ac9945..ccdfc2f661d9 100644
> > --- a/main/nano/APKBUILD
> > +++ b/main/nano/APKBUILD
> > _at_@ -1,13 +1,12 @@
> > # Contributor: Michael Mason <ms13sp_at_gmail.com>
> > -# Maintainer: Michael Zhou <zhoumichaely_at_gmail.com>
> > +# Maintainer: Natanael Copa <ncopa_at_alpinelinux.org>
> > pkgname=nano
> > pkgver=2.7.4
> > -pkgrel=0
> > +pkgrel=1
>
> I don't think we need to really rebuild the package for this. Hence
> pkgrel can be left untouched.

AFAIK pkgs.alpinelinux.org updates its info when the package is built, therefore I think it's good to bump pkgrel. Changing maintainer should be reflected in AL services.
 
In the old days (not that long ago) ncopa requested that each change in APKBUILD should lead to pkgrel bump, which is a safe and sane approach, even if a bit wasteful.

Some time ago APKBUILD improvements started to be applied without pkgrel bump, which can be acceptable in case of trivial changes (like my removal of empty vars here and there), but shouldn't be acceptable in general (like _builddir -> builddir rename and prepare() removal, because different code path in abuild is performed then).

Changing maintainer, while being trivial in diff, is important change, thus I strongly suggest to not drop pkgrel bump from this patch.

> Thanks!
>
> -|_eo
 
Regards,
Przemek



---
Unsubscribe:  alpine-aports+unsubscribe_at_lists.alpinelinux.org
Help:         alpine-aports+help_at_lists.alpinelinux.org
---
Received on Wed Jan 18 2017 - 21:52:01 UTC