Mail archive
alpine-aports

Re: [alpine-aports] [PATCH] main/perl-encode: upgrade to 2.88

From: Leonardo Arena <rnalrd_at_gmail.com>
Date: Mon, 23 Jan 2017 14:02:08 +0100

Hi,

On lun, 2017-01-23 at 13:51 +0200, Valery Kartel wrote:
> - fix doc
> - move *.pod to -doc
> - rename -piconv subpackage to -utils (because there are several
> utils)
> - move development script and data to -dev
> ---
>  main/perl-encode/APKBUILD | 50 +++++++++++++++++++++++++++++++++--
> ------------
>  1 file changed, 35 insertions(+), 15 deletions(-)
>

[...] 

> -# we split out /usr/bin/piconv to separate package to avoid conflict
> with
> -# piconv shipped with perl itself
> -piconv() {
> - pkgdesc="perl implementation of iconv"
> +utils() {
> + pkgdesc="perl Encode utils"
> + replaces="perl-utils"
> + mkdir -p "$subpkgdir"/usr
> + mv "$pkgdir"/usr/bin "$subpkgdir"/usr/
> +}
> +

there's no package "perl-utils" to be replaced. piconv and encguess
belong to main perl package:

(1/1) Installing perl-encode-utils (2.88-r0)
ERROR: perl-encode-utils-2.88-r0: trying to overwrite usr/bin/encguess
owned by perl-5.24.0-r0.
ERROR: perl-encode-utils-2.88-r0: trying to overwrite usr/bin/piconv
owned by perl-5.24.0-r0.

> +dev() {
> + default_dev
> + replaces="perl-dev"
>   mkdir -p "$subpkgdir"/usr/bin
> - mv "$pkgdir"/usr/bin/piconv "$subpkgdir"/usr/bin/
> + mv "$pkgdir"/usr/bin/enc2xs "$subpkgdir"/usr/bin || reutrn 1

Spelling error                                              ^

Other than these it looks okay to me.

Thanks!

-|_eo






---
Unsubscribe:  alpine-aports+unsubscribe_at_lists.alpinelinux.org
Help:         alpine-aports+help_at_lists.alpinelinux.org
---
Received on Mon Jan 23 2017 - 14:02:08 GMT