Mail archive
alpine-aports

Re: [alpine-aports] [PATCH] main/zeromq: upgrade to 4.2.2

From: Leonardo Arena <rnalrd_at_gmail.com>
Date: Thu, 23 Mar 2017 12:19:31 +0100

Hi,

On 23/03/2017 10:09, Valery Kartel wrote:
> - add check()
> - cleanups
> ---
> main/zeromq/APKBUILD | 35 ++++++++++++++---------------------
> 1 file changed, 14 insertions(+), 21 deletions(-)
>
> diff --git a/main/zeromq/APKBUILD b/main/zeromq/APKBUILD
> index 02c99c1c27..bba293fd83 100644
> --- a/main/zeromq/APKBUILD
> +++ b/main/zeromq/APKBUILD
> _at_@ -1,25 +1,17 @@
> # Contributor: Natanael Copa <ncopa_at_alpinelinux.org>
> # Maintainer: Natanael Copa <ncopa_at_alpinelinux.org>
> pkgname=zeromq
> -pkgver=4.1.5
> -pkgrel=1
> +pkgver=4.2.2
> +pkgrel=0
> pkgdesc="The ZeroMQ messaging library and tools"
> url="http://www.zeromq.org/"
> arch="all"
> license="LGPLv3+ with exceptions"
> -depends=""
> -makedepends="util-linux-dev libsodium-dev perl python2 asciidoc xmlto
> - autoconf automake"
> +makedepends="util-linux-dev libsodium-dev libunwind-dev
> + perl python2 asciidoc xmlto autoconf automake"
> subpackages="$pkgname-dev $pkgname-doc libzmq"
> -source="https://github.com/zeromq/zeromq4-1/releases/download/v$pkgver/$pkgname-$pkgver.tar.gz"
> -
> -builddir="$srcdir"/$pkgname-$pkgver
> -
> -prepare() {
> - cd "$builddir"
> - update_config_sub || return 1
> - default_prepare || return 1
> -}
> +source="https://github.com/zeromq/libzmq/releases/download/v$pkgver/$pkgname-$pkgver.tar.gz"
> +builddir="$srcdir/$pkgname-$pkgver"
>
> build() {
> cd "$builddir"
> _at_@ -32,20 +24,21 @@ build() {
> --infodir=/usr/share/info \
> --with-libsodium \
> || return 1
> - make || return 1
> + make
> +}
> +

If you remove "|| return 1" it might complicate to backport any patch to
stable branches.


> +check() {
> + make -C "$builddir" check
> }
>

Personally I'd not use "-C" option. I think it's less intuitive and not
in line with current trend.

> package() {
> - cd "$builddir"
> - make DESTDIR="$pkgdir" install || return 1
> + make -C "$builddir" DESTDIR="$pkgdir" install
> }

Both previous comments apply here.

Thanks!

|_eo






---
Unsubscribe:  alpine-aports+unsubscribe_at_lists.alpinelinux.org
Help:         alpine-aports+help_at_lists.alpinelinux.org
---
Received on Thu Mar 23 2017 - 12:19:31 GMT