Mail archive
alpine-aports

Re: [alpine-aports] [PATCH] testing/vdr: new plugin: vaapidevice, fix streamdev install path, grand config files to video group, cosmetics

From: Leonardo Arena <rnalrd_at_gmail.com>
Date: Tue, 20 Mar 2018 11:41:31 +0100

Hi,

sorry for the late review:

On Sat, Mar 3, 2018 at 2:07 PM, Taner Tas <taner76_at_gmail.com> wrote:

> ---
> testing/vdr/APKBUILD | 74 +++++++++++++++++++++++++-----
> ------
> testing/vdr/Make.config | 25 ++++++------
> testing/vdr/streamdev-fix-path.patch | 10 +++++
> 3 files changed, 74 insertions(+), 35 deletions(-)
> create mode 100644 testing/vdr/streamdev-fix-path.patch
>
>
 [snip]


> _at__at_ -38,19 +41,31 @@ prepare() {
> rm -rf ${builddir}/PLUGINS/src/skincurses
> cp -aP $srcdir/vdr-plugin-femon-${_femon_ver}
> ${builddir}/PLUGINS/src/femon
> cp -aP $srcdir/vdr-plugin-softhddevice-${_softhddevice_ver}
> ${builddir}/PLUGINS/src/softhddevice
> + cp -aP $srcdir/vdr-plugin-vaapidevice-${_vaapidevice_ver}
> ${builddir}/PLUGINS/src/vaapidevice
> cp -aP $srcdir/vdr-plugin-mpv-${_mpv_ver}
> ${builddir}/PLUGINS/src/mpv
> cp -aP $srcdir/vdr-plugin-vnsiserver-${_vnsiserver_ver}
> ${builddir}/PLUGINS/src/vnsiserver
> cp -aP $srcdir/vdr-plugin-streamdev-${_streamdev_ver}
> ${builddir}/PLUGINS/src/streamdev
> cd "$builddir"
> + cp "$srcdir"/Make.config "$builddir"
> default_prepare
> }
>
> build() {
> cd "$builddir"
> - cp $srcdir/Make.config $builddir
> + sed -i -e 's/LIBS =/LIBS=-lintl -lexecinfo/' Makefile
>

This should go into prepare(). Also a patch is preferable instead of
dynamic editing.



> make
> }
>
> +package() {
> + cd "$builddir"
> + source "$builddir"/Make.config
> + make -j1 DESTDIR="$pkgdir" install
>

Would be nice to fix parallel building, but it's okay for pushing as is.

Thanks!

/eo



---
Unsubscribe:  alpine-aports+unsubscribe_at_lists.alpinelinux.org
Help:         alpine-aports+help_at_lists.alpinelinux.org
---
Received on Tue Mar 20 2018 - 11:41:31 GMT