Mail archive
alpine-aports

Re: [alpine-aports] [PATCH] main/mesa: Upgrade to 18.0.0

From: Taner Tas <taner76_at_gmail.com>
Date: Tue, 24 Apr 2018 08:28:11 +0300

On Mon, 23 Apr 2018 21:20:26 +0200
Natanael Copa <ncopa_at_alpinelinux.org> wrote:

> > * Add aarch64 arch to use neon instructions
>
> It does not mention that we also enable vc4 driver for aarch64?
You're right, will be mentioned.

> > +armhf|aarch64)
> > _gallium_drivers="${_gallium_drivers},vc4"
> > - case "$CARCH" in
> > - armhf) CFLAGS="$CFLAGS -mfpu=neon";;
> > - esac
> > + CFLAGS="$CFLAGS -mfpu=neon"
>
> This breaks build on aarch64:
>
> checking whether the C compiler works... no
> configure: error: in `/home/ncopa/aports/main/mesa/src/mesa-18.0.0':
> configure: error: C compiler cannot create executables
> See `config.log' for more details
>
>
> config.log has this explanation:
>
> configure:4657: checking whether the C compiler works
> configure:4679: gcc -Os -mfpu=neon -D_XOPEN_SOURCE=700 -Os -Wl,--as-needed conftest.c >&5
> gcc: error: unrecognized command line option '-mfpu=neon'
>
> We cannot add -mfpu=neon to CFLAGS on aarch64
>
> But as I understand your patch, we want enable vc4 driver on aarch64 too?
>
> Is it ok if I apply it with this change:
>
> diff --git a/main/mesa/APKBUILD b/main/mesa/APKBUILD
> index c0a8c4f997..404b0385d4 100644
> --- a/main/mesa/APKBUILD
> +++ b/main/mesa/APKBUILD
> _at_@ -50,7 +50,9 @@ x86*)
> ;;
> armhf|aarch64)
> _gallium_drivers="${_gallium_drivers},vc4"
> - CFLAGS="$CFLAGS -mfpu=neon"
> + case "$CARCH" in
> + armhf) CFLAGS="$CFLAGS -mfpu=neon";;
> + esac
> ;;

Yes, vc4 can be enabled on aarch64 for Rpi3 too.
Enabling -mfpu=neon seems doesn't needed on aarch64, thus separately enabling on armhf is enough as mentiones above.
I prepared another PR on github with newer version and suggested changes.
Please refer to: https://github.com/alpinelinux/aports/pull/4107

Thanks for review.

-- 
Taner
---
Unsubscribe:  alpine-aports+unsubscribe_at_lists.alpinelinux.org
Help:         alpine-aports+help_at_lists.alpinelinux.org
---
Received on Tue Apr 24 2018 - 08:28:11 GMT