Mail archive
alpine-aports

Re: [alpine-aports] [PATCH] testing/pygal: New aport

From: Leonardo Arena <rnalrd_at_gmail.com>
Date: Wed, 30 May 2018 15:35:04 +0200

Hi,

please see some comments below.

On Wed, May 2, 2018 at 4:52 PM, Marian Buschsieweke <
marian.buschsieweke_at_ovgu.de> wrote:

> pygal is a dynamic SVG charting library written in python
> https://pygal.org
> ---
> testing/pygal/APKBUILD | 42 ++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 42 insertions(+)
> create mode 100644 testing/pygal/APKBUILD
>
> diff --git a/testing/pygal/APKBUILD b/testing/pygal/APKBUILD
> new file mode 100644
> index 0000000000..e459f22ec6
> --- /dev/null
> +++ b/testing/pygal/APKBUILD
> _at__at_ -0,0 +1,42 @@
> +# Maintainer: Marian Buschsieweke <marian.buschsieweke_at_ovgu.de>
> +pkgname=pygal
>


I think we should call it "py-gal" regardless of the actual upstream name,
for the sake of naming consistency of all pyhon packages.



> +pkgver=2.4.0
> +pkgrel=0
> +pkgdesc="pygal is a dynamic SVG charting library written in python"
> +url="https://pygal.org"
> +arch="noarch"
> +license="LGPL3"
> +makedepends="python2-dev python3-dev py-setuptools"
> +subpackages="py2-${pkgname}:_py2 py3-${pkgname}:_py3"
> +source="https://files.pythonhosted.org/packages/source/${pkgname:0:1}/$
> pkgname/$pkgname-$pkgver.tar.gz"
> +builddir="$srcdir"/$pkgname-$pkgver
> +
> +build() {
> + cd "$builddir"
> + python2 setup.py build || return 1
> + python3 setup.py build || return 1
> +}
> +
>


"|| return 1" can be omitted


Thanks!

/eo



---
Unsubscribe:  alpine-aports+unsubscribe_at_lists.alpinelinux.org
Help:         alpine-aports+help_at_lists.alpinelinux.org
---
Received on Wed May 30 2018 - 15:35:04 GMT