Hi,
please see few comments below.
On Sun, Jul 1, 2018 at 3:55 PM, Marian Buschsieweke <
marian.buschsieweke@ovgu.de> wrote:
> https://github.com/tgalal/python-axolotl> Python port of libsignal-protocol-java> ---> testing/py-axolotl/APKBUILD | 51 +++++++++++++++++++++++++++++++++++++> 1 file changed, 51 insertions(+)> create mode 100644 testing/py-axolotl/APKBUILD>> diff --git a/testing/py-axolotl/APKBUILD b/testing/py-axolotl/APKBUILD> new file mode 100644> index 0000000000..fe9e416195> --- /dev/null> +++ b/testing/py-axolotl/APKBUILD> @@ -0,0 +1,51 @@> +# Maintainer: Marian Buschsieweke <marian.buschsieweke@ovgu.de>> +pkgname=py-axolotl> +_pkgname="python-${pkgname#py-}"> +pkgver=0.1.42> +pkgrel=0> +pkgdesc="Python port of libsignal-protocol-java"> +url="https://github.com/tgalal/python-axolotl"> +arch="noarch"> +license="GPL3">
Please replace it with "GPL-3.0-only"
Please add the dependencies here instead of adding them into the
subpbackages.
depends="py-crypto py-protobuf py-axolotl-curve25519"
+makedepends="py-setuptools python2-dev python3-dev"
> +subpackages="py2-${pkgname#py-}:_py2 py3-${pkgname#py-}:_py3"> +source="$pkgname-$pkgver.tar.gz::https://github.com/tgalal/> $_pkgname/archive/$pkgver.tar.gz"> +builddir="$srcdir"/$_pkgname-$pkgver> +> +build() {> + cd "$builddir"> + python2 setup.py build> + python3 setup.py build> +}> +> +check() {> + cd "$builddir"> + python3 setup.py test>
Python 2 tests are missing.
> +}> +> +package() {> + mkdir -p "$pkgdir"> +}> +> +_py2() {> + depends="py2-crypto py2-protobuf py2-axolotl-curve25519">
Please do a variable substitution here instead. This is the approach used
for all the other python packages:
depends="${depends//py-/py2-}"
> + replaces="$pkgname">
This should not be needed.
> + _py python2> +}> +> +_py3() {> + depends="py3-crypto py3-protobuf py3-axolotl-curve25519">
See comment above.
Thanks!
/eo
Re: [alpine-aports] [PATCH 2/5] testing/gajim: New aport
Hi,
it seems that gettext-dev is missing as mdepends. Even after adding it
fails during tests phase with:
Now running: unit.test_protocol_caps
E
======================================================================
ERROR: test_protocol_caps (unittest.loader._FailedTest)
----------------------------------------------------------------------
ImportError: Failed to import test module: test_protocol_caps
Traceback (most recent call last):
File "<frozen importlib._bootstrap>", line 888, in _find_spec
AttributeError: 'DynamicImporter' object has no attribute 'find_spec'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/lib/python3.6/unittest/loader.py", line 153, in
loadTestsFromName
module = __import__(module_name)
File
"/home/larena/aports/testing/gajim/src/gajim-1.0.3/test/unit/test_protocol_caps.py",
line 7, in <module>
lib.setup_env()
File
"/home/larena/aports/testing/gajim/src/gajim-1.0.3/test/lib/__init__.py",
line 55, in setup_env
from gajim import gtkgui_helpers
File
"/home/larena/aports/testing/gajim/src/gajim-1.0.3/test/lib/../../gajim/gtkgui_helpers.py",
line 32, in <module>
from gi.repository import Gtk
File "/usr/lib/python3.6/site-packages/gi/importer.py", line 127, in
find_module
'introspection typelib not found' % namespace)
ImportError: cannot import name Gtk, introspection typelib not found
----------------------------------------------------------------------
Ran 1 test in 0.000s
FAILED (errors=1)
Care to review the patch?
Thanks!
/eo
On Sun, Jul 1, 2018 at 3:55 PM, Marian Buschsieweke <
marian.buschsieweke@ovgu.de> wrote:
> https://gajim.org/> A full featured and easy to use XMPP client> ---> testing/gajim/APKBUILD | 29 +++++++++++++++++++++++++++++> 1 file changed, 29 insertions(+)> create mode 100644 testing/gajim/APKBUILD>> diff --git a/testing/gajim/APKBUILD b/testing/gajim/APKBUILD> new file mode 100644> index 0000000000..7b51e04212> --- /dev/null> +++ b/testing/gajim/APKBUILD> @@ -0,0 +1,29 @@> +# Maintainer: Marian Buschsieweke <marian.buschsieweke@ovgu.de>> +pkgname=gajim> +pkgver=1.0.3> +pkgrel=0> +pkgdesc="A full featured and easy to use XMPP client"> +url="https://gajim.org/"> +arch="noarch"> +license="GPL3"> +depends="py3-cairo py3-gobject3 py3-asn1 py3-nbxmpp py3-openssl"> +makedepends="py-setuptools python3-dev"> +source="https://$pkgname.org/downloads/1.0/$pkgname-$pkgver.tar.bz2"> +builddir="$srcdir"/$pkgname-$pkgver> +> +build() {> + cd "$builddir"> + python3 setup.py build> +}> +> +check() {> + cd "$builddir"> + python3 setup.py test> +}> +> +package() {> + cd "$builddir"> + python3 setup.py install --prefix=/usr --root="$pkgdir"> +}> +> +sha512sums="a6d7f92a22a9dddc8a4b07eda0aae0b6fb4db57c73133ee19937f7e2a2a8> 2c5351051d1f3627c94a44434276ed001b83d375f708f177962125af66cda8579ec8> gajim-1.0.3.tar.bz2"> --> 2.18.0>>>> ---> Unsubscribe: alpine-aports+unsubscribe@lists.alpinelinux.org> Help: alpine-aports+help@lists.alpinelinux.org> --->>