Mail archive
alpine-aports

Re: [alpine-aports] [PATCH] testing/cava: new aport

From: Leonardo Arena <rnalrd_at_gmail.com>
Date: Wed, 11 Jul 2018 15:40:32 +0200

Hi,

please see some comments below:

On Sun, Jul 1, 2018 at 4:45 PM, Sascha Paunovic <azarus_at_posteo.net> wrote:

> ---
> testing/cava/APKBUILD | 38 ++++++++++++++++++++++++++++++++++++++
> 1 file changed, 38 insertions(+)
> create mode 100644 testing/cava/APKBUILD
>
> diff --git a/testing/cava/APKBUILD b/testing/cava/APKBUILD
> new file mode 100644
> index 0000000000..b2dfe566e7
> --- /dev/null
> +++ b/testing/cava/APKBUILD
> _at__at_ -0,0 +1,38 @@
> +# Contributor: Sascha Paunovic <azarus_at_posteo.net>
> +# Maintainer: Sascha Paunovic <azarus_at_posteo.net>
> +#TODO: pulseaudio & sndio subpackage
> +pkgname=cava
> +pkgver=0.6.1
> +pkgrel=0
> +pkgdesc="console based audio visualizer for ALSA & more"
> +url="https://github.com/karlstav/cava"
> +arch="all"
> +license="MIT"
> +makedepends="fftw-dev ncurses-dev alsa-lib-dev libtool"
>


Automake and autoconf are missing.



> +source="$pkgname-$pkgver.tar.gz::https://github.com/
> karlstav/$pkgname/archive/$pkgver.tar.gz"
> +builddir="$srcdir/$pkgname-$pkgver"
> +
> +build() {
> + cd "$builddir"
> + autoreconf -if
>


autoreconf should be moved into "prepare()" which should run also
"default_prepare" first.



> + ./configure \
> + --build=$CBUILD \
> + --host=$CHOST \
> + --prefix=/usr \
> + --sysconfdir=/etc \
> + --mandir=/usr/share/man \
> + --localstatedir=/var
> + make
> +}
> +
> +check() {
> + cd "$builddir"
> + make check # currently doesn't do much, but better than nothing
> +}
> +
> +package() {
> + cd "$builddir"
> + make DESTDIR="$pkgdir" install
> +}
> +
> +sha512sums="fb8a685f5c758ca1d95d3bbafadd4dbbf109592b6c3052b0821c2f69f342
> 3e0af7657de4c3c1cdbd1523748bf56a09cbf706afa404051a6fba8139ca128ebecb
> cava-0.6.1.tar.gz"
>
>

Everything else looks good, thanks!

/eo



---
Unsubscribe:  alpine-aports+unsubscribe_at_lists.alpinelinux.org
Help:         alpine-aports+help_at_lists.alpinelinux.org
---
Received on Wed Jul 11 2018 - 15:40:32 GMT