Mail archive
alpine-aports

Re: [alpine-aports] [PATCH] testing/simple-mtpfs: new aport

From: Leonardo Arena <rnalrd_at_gmail.com>
Date: Wed, 18 Jul 2018 12:12:40 +0200

Hi,

sorry for the late review. Please see few comments below.

On Sat, Jun 23, 2018 at 9:40 PM, Milan P. Stanić <mps_at_arvanta.net> wrote:

> https://github.com/phatina/simple-mtpfs
> filesystem driver and CLI utility for mounting MTP based devices
> ---
> testing/simple-mtpfs/APKBUILD | 30 ++++++++++++++++++++++++++++++
> 1 file changed, 30 insertions(+)
> create mode 100644 testing/simple-mtpfs/APKBUILD
>
> diff --git a/testing/simple-mtpfs/APKBUILD b/testing/simple-mtpfs/APKBUILD
> new file mode 100644
> index 0000000000..81d3c431d6
> --- /dev/null
> +++ b/testing/simple-mtpfs/APKBUILD
> _at__at_ -0,0 +1,30 @@
> +# Contributor: Milan P. Stanić <mps_at_arvanta.net>
> +# Maintainer: Milan P. Stanić <mps_at_arvanta.net>
> +pkgname=simple-mtpfs
> +pkgver=0.3.0
> +pkgrel=0
> +pkgdesc="filesystem driver and CLI utility for MTP based devices"
> +url="https://github.com/phatina/simple-mtpfs"
> +arch="all"
> +license="GPL-2"
>


The license ID is invalid according to the standard we use:
https://spdx.org/licenses/



> +depends=""
> +makedepends="libmtp-dev libusb-dev fuse-dev"
> +install=""
>


Optionally you may remove empy variables.


+subpackages="$pkgname-doc"
> +source="https://github.com/phatina/simple-mtpfs/archive/$
> {pkgname}-${pkgver}.tar.gz"
> +builddir="$srcdir/${pkgname}-${pkgname}-${pkgver}"
> +
> +build() {
> + cd "$builddir"
> + ./autogen.sh
>


Indent broken. In any case "autogen.sh" belongs to prepare() function.

Thanks!

/eo



---
Unsubscribe:  alpine-aports+unsubscribe_at_lists.alpinelinux.org
Help:         alpine-aports+help_at_lists.alpinelinux.org
---
Received on Wed Jul 18 2018 - 12:12:40 UTC