Mail archive
alpine-aports

Re: [alpine-aports] [PATCH 4/5] testing/py-axolotl: New aport

From: Leonardo Arena <rnalrd_at_gmail.com>
Date: Fri, 20 Jul 2018 10:06:01 +0200

Hi,

please see few comments below.

On Sun, Jul 1, 2018 at 3:55 PM, Marian Buschsieweke <
marian.buschsieweke_at_ovgu.de> wrote:

> https://github.com/tgalal/python-axolotl
> Python port of libsignal-protocol-java
> ---
> testing/py-axolotl/APKBUILD | 51 +++++++++++++++++++++++++++++++++++++
> 1 file changed, 51 insertions(+)
> create mode 100644 testing/py-axolotl/APKBUILD
>
> diff --git a/testing/py-axolotl/APKBUILD b/testing/py-axolotl/APKBUILD
> new file mode 100644
> index 0000000000..fe9e416195
> --- /dev/null
> +++ b/testing/py-axolotl/APKBUILD
> _at__at_ -0,0 +1,51 @@
> +# Maintainer: Marian Buschsieweke <marian.buschsieweke_at_ovgu.de>
> +pkgname=py-axolotl
> +_pkgname="python-${pkgname#py-}"
> +pkgver=0.1.42
> +pkgrel=0
> +pkgdesc="Python port of libsignal-protocol-java"
> +url="https://github.com/tgalal/python-axolotl"
> +arch="noarch"
> +license="GPL3"
>


Please replace it with "GPL-3.0-only"

Please add the dependencies here instead of adding them into the
subpbackages.

depends="py-crypto py-protobuf py-axolotl-curve25519"

+makedepends="py-setuptools python2-dev python3-dev"
> +subpackages="py2-${pkgname#py-}:_py2 py3-${pkgname#py-}:_py3"
> +source="$pkgname-$pkgver.tar.gz::https://github.com/tgalal/
> $_pkgname/archive/$pkgver.tar.gz"
> +builddir="$srcdir"/$_pkgname-$pkgver
> +
> +build() {
> + cd "$builddir"
> + python2 setup.py build
> + python3 setup.py build
> +}
> +
> +check() {
> + cd "$builddir"
> + python3 setup.py test
>


Python 2 tests are missing.



> +}
> +
> +package() {
> + mkdir -p "$pkgdir"
> +}
> +
> +_py2() {
> + depends="py2-crypto py2-protobuf py2-axolotl-curve25519"
>


Please do a variable substitution here instead. This is the approach used
for all the other python packages:

depends="${depends//py-/py2-}"



> + replaces="$pkgname"
>


This should not be needed.



> + _py python2
> +}
> +
> +_py3() {
> + depends="py3-crypto py3-protobuf py3-axolotl-curve25519"
>


See comment above.


Thanks!

/eo



---
Unsubscribe:  alpine-aports+unsubscribe_at_lists.alpinelinux.org
Help:         alpine-aports+help_at_lists.alpinelinux.org
---
Received on Fri Jul 20 2018 - 10:06:01 GMT