Mail archive
alpine-aports

[alpine-aports] [PATCH] main/faac: fix build with gcc8 (useful -Werror)

From: alpine-mips-patches <info_at_mobile-stream.com>
Date: Mon, 26 Nov 2018 22:05:44 +0000

gcc8 reports meaningful -Wpointer-compare case in common/mp4v2/rtphint.cpp:345
however fixing it directly will enable previously unused code block. This may
be dangerous since the bundled mp4v2 library is *very* old and there is no test
suite. Moreover, upstream no longer ships mp4v2 at all in faac-1.29+.

So just pass -fpermissive in CXXFLAGS for now to avoid any behaviour changes.

This work-around should be removed on faac upgrade or proper fix.
---
 main/faac/APKBUILD | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/main/faac/APKBUILD b/main/faac/APKBUILD
index f9267b453e..23fedfbae2 100644
--- a/main/faac/APKBUILD
+++ b/main/faac/APKBUILD
_at_@ -1,7 +1,7 @@
 # Maintainer: Natanael Copa <ncopa_at_alpinelinux.org>
 pkgname=faac
 pkgver=1.28
-pkgrel=11
+pkgrel=12
 pkgdesc="FAAC is an AAC audio encoder."
 url="http://www.audiocoding.com/"
 arch="all"
_at_@ -34,6 +34,7 @@ prepare() {
 
 build() {
 	cd "$srcdir"/$pkgname-$pkgver
+	CXXFLAGS="$CXXFLAGS -fpermissive" \
 	./configure \
 		--build=$CBUILD \
 		--host=$CHOST \
-- 
2.19.1
---
Unsubscribe:  alpine-aports+unsubscribe_at_lists.alpinelinux.org
Help:         alpine-aports+help_at_lists.alpinelinux.org
---
Received on Mon Nov 26 2018 - 22:05:44 UTC