Mail archive
alpine-aports

Re: [alpine-aports] [PATCH] testing/firefox: upgrade to 65.0

From: Leonardo Arena <rnalrd_at_gmail.com>
Date: Tue, 12 Feb 2019 14:00:08 +0100

Hi,

see few comments below.

On Mon, Feb 11, 2019 at 5:56 PM Bradley Saulteaux <bradsoto_at_gmail.com>
wrote:

> https://www.firefox.com/
> Firefox web browser
> ---
> .../firefox/0002-Use-C99-math-isfinite.patch | 17 -----
> testing/firefox/APKBUILD | 41 +++++-----
> testing/firefox/disable-moz-stackwalk.patch | 10 +--
> testing/firefox/fix-arm-atomics-grsec.patch | 74 ++++++++-----------
> testing/firefox/fix-arm-version-detect.patch | 13 ----
> testing/firefox/fix-seccomp-bpf.patch | 26 +++----
> testing/firefox/fix-stack-overflow.patch | 45 -----------
> testing/firefox/fix-toolkit.patch | 8 +-
> testing/firefox/fix-tools.patch | 18 ++---
> testing/firefox/fix-webrtc-glibcisms.patch | 18 ++---
> testing/firefox/rust-unitialized-field.patch | 11 ++-
> 11 files changed, 94 insertions(+), 187 deletions(-)
> delete mode 100644 testing/firefox/0002-Use-C99-math-isfinite.patch
> delete mode 100644 testing/firefox/fix-arm-version-detect.patch
> delete mode 100644 testing/firefox/fix-stack-overflow.patch
>
> diff --git a/testing/firefox/0002-Use-C99-math-isfinite.patch
> b/testing/firefox/0002-Use-C99-math-isfinite.patch
> deleted file mode 100644
> index ba4f5cfb3d..0000000000
> --- a/testing/firefox/0002-Use-C99-math-isfinite.patch
> +++ /dev/null
> _at__at_ -1,17 +0,0 @@
> ---- ./xpcom/ds/nsMathUtils.h.orig
> -+++ ./xpcom/ds/nsMathUtils.h
> -_at__at_ -104,12 +104,12 @@
> - #ifdef WIN32
> - // NOTE: '!!' casts an int to bool without spamming MSVC warning C4800.
> - return !!_finite(aNum);
> --#elif defined(XP_DARWIN)
> -+#elif defined(XP_DARWIN) || defined(_GLIBCXX_CMATH)
> - // Darwin has deprecated |finite| and recommends |isfinite|. The
> former is
> - // not present in the iOS SDK.
> - return std::isfinite(aNum);
> - #else
> -- return finite(aNum);
> -+ return isfinite(aNum);
> - #endif
> - }
> -
> diff --git a/testing/firefox/APKBUILD b/testing/firefox/APKBUILD
> index b31c1997b7..c53275e7b1 100644
> --- a/testing/firefox/APKBUILD
> +++ b/testing/firefox/APKBUILD
> _at__at_ -1,7 +1,7 @@
> # Contributor: William Pitcock <nenolod_at_dereferenced.org>
> # Maintainer: Natanael Copa <ncopa_at_alpinelinux.org>
> pkgname=firefox
> -pkgver=62.0.3
> +pkgver=65.0
> _pkgver=$pkgver
> _xulver=$pkgver
> pkgrel=2
> _at__at_ -11,6 +11,7 @@ url="https://www.firefox.com/"
> arch="x86_64"
> license="GPL LGPL MPL"
> depends=""
> +# icu-dev


icu has been recently updated to 63.1. As I understand is needed by firefox
65.


>
> makedepends="
> alsa-lib-dev
> autoconf2.13
> _at__at_ -18,6 +19,7 @@ makedepends="
> bsd-compat-headers
> bzip2-dev
> cargo
> + cbindgen
>

We don't have a package for it yet.

Thanks!

/eo



---
Unsubscribe:  alpine-aports+unsubscribe_at_lists.alpinelinux.org
Help:         alpine-aports+help_at_lists.alpinelinux.org
---
Received on Tue Feb 12 2019 - 14:00:08 UTC