Mail archive
alpine-aports

Re: [alpine-aports] [PATCH] community/fzf: Add neovim subpackage

From: Chloe Kudryavtsev <toast_at_toastin.space>
Date: Tue, 5 Mar 2019 15:54:09 -0500

On 3/5/2019 11:00 AM, Matt Hill wrote:
> Basic integration for Neovim

>
> + $pkgname-neovim:nvim:noarch

> +nvim() {
> + pkgdesc="fzf vim plugin"
> + cd "$builddir"
> + mkdir -p "$subpkgdir"/usr/share/nvim/runtime/plugin/
> + install -Dm0644 plugin/fzf.vim "$subpkgdir"/usr/share/nvim/runtime/plugin/
> +}
> +

Shouldn't this be s/nvim/vim/?
Iirc, nvim can take advantage of vim's runtime, but not vice-versa.
The plugin works for both, so we should either install the file twice,
or once, but for vim.

Also, I'd imagine we want an install_if, so it's autoinstalled when
vim/nvim *and* fzf are installed.
(note that the above is an argument for having two subpackages).


---
Unsubscribe:  alpine-aports+unsubscribe_at_lists.alpinelinux.org
Help:         alpine-aports+help_at_lists.alpinelinux.org
---
Received on Tue Mar 05 2019 - 15:54:09 UTC