Mail archive
alpine-aports

Re: [alpine-aports] [PATCH] testing/virt-top: new aport

From: Fernando Casas Schössow <casasfernando_at_outlook.com>
Date: Tue, 5 Mar 2019 21:39:11 +0000

Hi Leonardo,

Please find attached a new patch with all the suggested changes.
Let me know if I should change anything else.

Thanks.
Kind regards,

Fernando

On mar, mar 5, 2019 at 3:17 PM, Leonardo <rnalrd_at_gmail.com> wrote:
Hi, On 2/8/19 12:55 AM, Fernando Casas Schössow wrote: [ snip ]
diff --git a/testing/virt-top/APKBUILD b/testing/virt-top/APKBUILD new file mode 100644 index 0000000000..c92bbabe98 --- /dev/null +++ b/testing/virt-top/APKBUILD _at__at_ -0,0 +1,78 @@ +# Contributor: Fernando Casas Schossow <casasfernando@outlook.com<mailto:casasfernando@outlook.com>> +# Maintainer: Fernando Casas Schossow <casasfernando@outlook.com<mailto:casasfernando@outlook.com>> +pkgname=virt-top +pkgver=1.0.8 +pkgrel=0 +pkgdesc="Utility like top(1) for displaying virtualization stats" +url="http://people.redhat.com/~rjones/virt-top/" +arch="all"
Currently "arch" should be only for x86_64, since ocaml-xml-light is built only for this arch.
+license="GPLv2+" +makedepends="ocaml ocaml-ocamldoc ocaml-curses ocaml-curses-dev ocaml-extlib ocaml-extlib-dev ocaml-xml-light ocaml-xml-light-dev ocaml-csv ocaml-csv-dev ocaml-calendar ocaml-calendar-dev ocaml-libvirt ocaml-libvirt-dev ocaml-gettext ocaml-gettext-dev ocaml-fileutils ocaml-fileutils-dev ocaml-findlib-dev ocamlbuild ncurses-dev libvirt-dev perl gettext gettext-dev gawk autoconf"
Would you please make this more readable? Either one per line or break at ~80 chars.
+subpackages="$pkgname-lang $pkgname-doc" +source="http://people.redhat.com/~rjones/$pkgname/files/$pkgname-$pkgver.tar.gz + 0001-Disable-warning-about-immutable-strings-for-OCaml-4..patch + 0002-Move-upstream-translations-from-Tranifex-to-Zanata.patch + 0003-Update-translations-from-Zanata.patch + 0004-build-Add-g-flag-to-ocamlopt.patch + 0005-Rename-source-directory-and-files.patch + 0006-Enable-same-warnings-as-libguestfs.patch + 0007-Remove-x-executable-permission-on-several-source-fil.patch + 0008-Refresh-HACKING-file.patch + 0009-Fix-po-POTFILES-for-new-location-of-source-files.patch + 0010-Update-PO-files.patch + 0011-Remove-support-for-OCaml-Calendar-v1.patch + 0012-src-Fix-some-comments-which-referred-to-the-old-file.patch + 0013-Split-up-huge-Top-module-into-smaller-modules.patch + 0014-Move-block_in_bytes-entirely-to-the-presentation-lay.patch + 0015-Remove-unused-variable-is_calendar2.patch + 0016-Use-virConnectGetAllDomainStats-API-to-collect-domai.patch + 0017-chmod-x-COPYING-files.patch" +builddir="$srcdir/$pkgname-$pkgver" + +build() { + cd "$builddir" + export OCAMLPARAM="safe-string=0,_" + autoconf
Please move "autoconf" it into prepare() function. Don't forget to call default_prepare in it. Thank you! /eo







---
Unsubscribe:  alpine-aports+unsubscribe_at_lists.alpinelinux.org
Help:         alpine-aports+help_at_lists.alpinelinux.org
---
Received on Tue Mar 05 2019 - 21:39:11 UTC