[alpine-aports] Re: [PATCH 1/2] testing/samurai: remove check()
Sorry I missed this - can you Cc me on future patches?
+1 on patch 2/2
> There is no provided test suite. The `build.ninja` is meant to be an
> alternative build mechanism and requires modification to set desired
> compile and link flags.
> So, running `./samu` in check() will rebuild itself before packaging,
> but without the CFLAGS and LDFLAGS set by abuild, resulting in an
> unoptimized binary.
Hm, I understand the problem, but having samu build itself seems like a
pretty good test. I'd rather fix the CFLAGS/LDFLAGS than nix the check()
entirely. Testing a full gcc bootstrap involves a similar process.
Received on Sun Mar 24 2019 - 21:57:01 UTC