Mail archive
alpine-aports

Re: [alpine-aports] [PATCH v3 01/10] community/py-factory-boy: adopt APKBUILD

From: Natanael Copa <ncopa_at_alpinelinux.org>
Date: Thu, 4 Apr 2019 13:56:08 +0200

On Wed, 3 Apr 2019 16:16:33 -0400
Drew DeVault <sir_at_cmpwn.com> wrote:

> ---
> community/py-factory-boy/APKBUILD | 17 ++++++++++-------
> 1 file changed, 10 insertions(+), 7 deletions(-)
>
> diff --git a/community/py-factory-boy/APKBUILD b/community/py-factory-boy/APKBUILD
> index 24b0876c58..cdfcea6732 100644
> --- a/community/py-factory-boy/APKBUILD
> +++ b/community/py-factory-boy/APKBUILD
> _at_@ -1,17 +1,19 @@
> # Contributor: Kaarle Ritvanen <kaarle.ritvanen_at_datakunkku.fi>
> -# Contributor: Drew DeVault <sir_at_cmpwn.com>
> -# Maintainer: Kaarle Ritvanen <kaarle.ritvanen_at_datakunkku.fi>
> +# Maintainer: Drew DeVault <sir_at_cmpwn.com>

I assume you have verified this with Kaarle (kunkku)?

> pkgname=py-factory-boy
> _pkgname=factory_boy
> pkgver=2.11.1
> -pkgrel=1
> +pkgrel=2
> pkgdesc="A verstile test fixtures replacement based on thoughtbot's factory_girl for Ruby"
> url=https://github.com/rbarrois/factory_boy
> arch=noarch
> license=MIT
> -depends="py-faker py-six"
> -makedepends="py-setuptools"
> -checkdepends="py-mock py-django py-sqlalchemy"
> +_py2_deps="py2-faker py2-six"
> +_py2_deps="py3-faker py3-six"

Typo here. _py2 should be _py3

> +makedepends="$_py2_deps $_py3_deps py2-setuptools py3-setuptools"
> +checkdepends="
> + py2-mock py3-mock py2-django py3-django py2-sqlalchemy py3-sqlalchemy
> +"
> subpackages="py2-${pkgname#py-}:_py2 py3-${pkgname#py-}:_py3"
> source="$pkgname-$pkgver.tar.gz::https://github.com/FactoryBoy/$_pkgname/archive/$pkgver.tar.gz"
> builddir=$srcdir/$_pkgname-$pkgver
> _at_@ -47,12 +49,13 @@ package() {
>
> _py2() {
> replaces="py-factory-boy"
> - depends="py-six"
> + depends="$_py2_deps"
> cd "$builddir"
> _py python2
> }
>
> _py3() {
> + depends="$_py3_deps"
> cd "$builddir"-py3
> _py python3
> }

I'm gonna clean up the typo for you and merge together with the python 3.7 rebuild.

Thanks!

-nc


---
Unsubscribe:  alpine-aports+unsubscribe_at_lists.alpinelinux.org
Help:         alpine-aports+help_at_lists.alpinelinux.org
---
Received on Thu Apr 04 2019 - 13:56:08 UTC