~alpine/aports

Re: [alpine-aports] [PATCH 5/6] testing/pulseview: New aport

Milan P. Stanić <mps@arvanta.net>
Details
Message ID
<20190604213923.GA5264@arya.arvanta.net>
Sender timestamp
1559684363
DKIM signature
missing
Download raw message
Hi,

On Mon, 2019-06-03 at 21:15, Marian Buschsieweke wrote:
> Hi,
> 
> thanks for pointing out that issue. I missed that doxygen is required to
> generate the C++ bindings for libsigrok. I added a patch to fix that.

Applied patch with reverting deletion of the 'cd $builddir'.
Today we discussed this and concluded that is 'best practice' is to keep
'cd $builddir' till the main repository become ready for this change.
Although this is not a bug (remove/don't use 'cd $builddir') for now I
decided to keep it if there are no strong reasons for removal.

Sorry for misleading you.

> I also
> updated the patch for pulseview to no longer contain unneeded "${}" and also no
> "cd $builddir".

Applied.

n.b. Please send patches to alpine-aports@lists.alpinelinux.org
(patchwork.alpinelinux.org) where more people can review, help and
apply.

Thank you for helping Alpine.

-- 
Best regards

> Kind regards,
> Marian
...


---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---
Reply to thread Export thread (mbox)