Hello,

Please review and commit this package.

Thanks
Cameron

On Sun, 2009-03-01 at 22:06 -0600, Cameron Banta wrote:
> Hello,
> 
> Please review and commit this package.

Nice!

looks very good.

some nitpick follows..

> 
> Thanks
> Cameron 
> 
> 
> 
> 
> 
> 
> differences
> between files
> attachment
> (0001-extra-ghostscript-initial-commit.patch)
> 
> From 3d266799b506a959a98671287f5321b15b74b998 Mon Sep 17 00:00:00 2001
> From: Cameron Banta <cbanta@gmail.com>
> Date: Mon, 2 Mar 2009 03:52:12 +0000
> Subject: [PATCH] initial commit
> 
> ---
>  extra/ghostscript/APKBUILD |   48
> ++++++++++++++++++++++++++++++++++++++++++++
>  1 files changed, 48 insertions(+), 0 deletions(-)
>  create mode 100644 extra/ghostscript/APKBUILD
> 
> diff --git a/extra/ghostscript/APKBUILD b/extra/ghostscript/APKBUILD
> new file mode 100644
> index 0000000..dc5f75f
> --- /dev/null
> +++ b/extra/ghostscript/APKBUILD
> @@ -0,0 +1,48 @@
> +# Contributor: Cameron Banta <cbanta@gmail.com>
> +# Maintainer: Cameron Banta <cbanta@gmail.com>
> +pkgname=ghostscript
> +pkgver=8.64
> +pkgrel=0
> +pkgdesc="An interpreter for the PostScript language and for PDF"
> +url="http://ghostscript.com/"
> +license="GPL"
> +depends="uclibc"
> +makedepends=""
> +install=
> +#subpackages="$pkgname-doc $pkgname-dev"

this line should be removed.

> +subpackages="$pkgname-doc"
> +source="http://ghostscript.com/releases/$pkgname-$pkgver.tar.gz"
> +
> +build() {
> +       cd "$srcdir/$pkgname-$pkgver"
> +
> +       ./configure --prefix=/usr \
> +               --sysconfdir=/etc \
> +               --mandir=/usr/share/man \
> +               --infodir=/usr/share/info \
> +               --with-drivers=FILES \
> +               --disable-cups --disable-gtk --disable-cairo \
> +               --docdir=/usr/share/doc/"$pkgname"
> +       make || return 1
> +       make DESTDIR="$pkgdir" install
> +
> +       # license and copying
> +       install -m644 -D "$srcdir/$pkgname-$pkgver/LICENSE" \
> +               "$pkgdir/usr/share/licenses/$pkgname/LICENSE"
> +       install -m644 -D "$srcdir/$pkgname-$pkgver/doc/COPYING" \
> +               "$pkgdir/usr/share/licenses/$pkgname/COPYING"
> +       
> +
> +
> +       # make the doc and examples more alpine like 
> +       #       (the --docdir above doesn't seem to work so good)

Nice that you comment why you do like you do. 

> +       mkdir -p "$pkgdir/usr/share/doc/$pkgname"
> +       mv "$pkgdir/usr/share/$pkgname/$pkgver/doc" "$pkgdir/usr/share/doc/$pkgname"
> +       mv "$pkgdir/usr/share/$pkgname/$pkgver/examples" "$pkgdir/usr/share/doc/$pkgname"
> +       
> +
> +       # install -m755 -D "$srcdir"/$pkgname.initd "$pkgdir"/etc/init.d/$pkgname
> +       # install -m644 -D "$srcdir"/$pkgname.confd "$pkgdir"/etc/conf.d/$pkgname

those 2 lines should be removed. Unlikely that ghostscript will ever
have an init.d script.

> +}
> +
> +md5sums="dd927ecf7e4db38b62be3dc17b1b04d2  ghostscript-8.64.tar.gz"

I apply as is. thanks!

-nc



---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---

On Mon, Mar 2, 2009 at 11:00 AM, Natanael Copa <natanael.copa@gmail.com>wrote:

> On Sun, 2009-03-01 at 22:06 -0600, Cameron Banta wrote:
> > Hello,
> >
> > Please review and commit this package.
>
> Nice!
>
> looks very good.
>
> some nitpick follows..
>
>
This patch cleans up the nitpick.

Thanks,
Cameron

On Wed, 2009-03-04 at 07:04 -0600, Cameron Banta wrote:
> On Mon, Mar 2, 2009 at 11:00 AM, Natanael Copa
> <natanael.copa@gmail.com> wrote:
>         On Sun, 2009-03-01 at 22:06 -0600, Cameron Banta wrote:
>         > Hello,
>         >
>         > Please review and commit this package.
>         
>         
>         Nice!
>         
>         looks very good.
>         
>         some nitpick follows..
>         
> 
> This patch cleans up the nitpick.

applied. thanks!

> 
> Thanks,
> Cameron



---
Unsubscribe:  alpine-devel+unsubscribe@lists.alpinelinux.org
Help:         alpine-devel+help@lists.alpinelinux.org
---