Mail archive
alpine-devel

Re: [alpine-devel] new aport ncftp

From: Natanael Copa <natanael.copa_at_gmail.com>
Date: Mon, 26 Jan 2009 11:14:01 +0100

On Sun, 2009-01-25 at 13:04 +0000, Carlo Landmeter wrote:
> New aport ncftp. Please see attached git patch.

cool!

>
> Natanael, I still kept the license as arch does.
> If you have a new way of doing it please let me know and ill update
> the apkbuild.

ok. no i dont have any good idea how to deal with it.

>
> Carlo
>
>
>
>
>
>
>
>
> differences
> between files
> attachment
> (0001-extra-ncftp-new-aport.patch)
>
> From d45adc6f3afe454bbfac9b58ec794daca7b96dfb Mon Sep 17 00:00:00 2001
> From: Carlo Landmeter <clandmeter_at_gmail.com>
> Date: Sun, 25 Jan 2009 13:00:35 +0000
> Subject: [PATCH] extra/ncftp: new aport
>
> ---
> extra/ncftp/APKBUILD | 22 ++++++++++++++++++++++
> 1 files changed, 22 insertions(+), 0 deletions(-)
> create mode 100644 extra/ncftp/APKBUILD
>
> diff --git a/extra/ncftp/APKBUILD b/extra/ncftp/APKBUILD
> new file mode 100644
> index 0000000..3edb234
> --- /dev/null
> +++ b/extra/ncftp/APKBUILD
> _at_@ -0,0 +1,22 @@
> +# Maintainer: Carlo Landmeter <clandmeter at gmail>
> +pkgname=ncftp
> +pkgver=3.2.2
> +pkgrel=0
> +pkgdesc="A set of free application programs implementing FTP"
> +url="http://www.ncftp.com/"
> +license="custom"
> +depends="ncurses"
> +makedepends=""

If ncurses is linked in, then it will most likely need the ncurses-dev
package during buildtime so it should be added to makedepends.

> +source="ftp://ftp.$pkgname.com/$pkgname/$pkgname-$pkgver-src.tar.bz2"

The packages contains manpages. We should have a -doc subpackage.

> +
> +build ()
> +{
   ^^^
git complained about trailing whitespace in the row here over.

> + cd ${srcdir}/${pkgname}-${pkgver} || return 1

If we consequesntly quote the "$srcdir" and "$pkgdir" will we be able to
build the stuff from paths with spaces. If not, things might break if a
parend directory name contains spaces.

> + install -d ${pkgdir}/usr/share | return 1
> + ./configure --prefix=/usr --sysconfdir=/etc || return 1
> + make || return 1
> + make prefix=${pkgdir}/usr mandir=${pkgdir}/usr/share/man
> install || return 1

make install seems to respect DESTDIR. So we set the mandir
with ./configure and use only 'make DESTDIR="$pkgdir" install'

> + install -D doc/LICENSE.txt
> ${pkgdir}/usr/share/licenses/${pkgname}/LICENSE || return 1
> +}
> +
> +md5sums="b2b4b2fd38c81754b8f13895d784d491 ncftp-3.2.2-src.tar.bz2"
> --
> 1.6.1

I know it is details, but I think we can do better than Arch linux :)

I committed your patch and did the above changes.

Thanks alot!

btw. I have a cronjob that updates this list of packages needing to be
ported:
http://dev.alpinelinux.org/~ncopa/alpine/pkg-todo.txt


-nc



---
Unsubscribe:  alpine-devel+unsubscribe_at_lists.alpinelinux.org
Help:         alpine-devel+help_at_lists.alpinelinux.org
---
Received on Mon Jan 26 2009 - 11:14:01 UTC