Mail archive
alpine-devel

Re: [alpine-devel] core/nano

From: Natanael Copa <natanael.copa_at_gmail.com>
Date: Mon, 23 Feb 2009 13:37:34 +0100

On Fri, 2009-02-20 at 20:37 +0000, Michael Mason wrote:
> Please apply patch.
> My first one, so please let me know if there is anything wrong or
> could be done better.

very nice!
It is a very good first APKBUILD.

> Thx
>
>
>
>
>
>
>
>
>
> differences
> between files
> attachment
> (0001-nano-for-alpinev1.9-first-package.patch)
>
> From a81e121ded6440aede878e7a4ba68bc92a435fe9 Mon Sep 17 00:00:00 2001
> From: ms13sp <ms13sp_at_gmail.com>
> Date: Fri, 20 Feb 2009 20:31:59 +0000
> Subject: [PATCH] nano for alpinev1.9 first package
>
> ---
> core/nano/APKBUILD | 33 +++++++++++++++++++++++++++++++++
> 1 files changed, 33 insertions(+), 0 deletions(-)
> create mode 100644 core/nano/APKBUILD
>
> diff --git a/core/nano/APKBUILD b/core/nano/APKBUILD

I think that we maybe dont want this in core but in extra. Not really
needed to boot/build the system.

> new file mode 100644
> index 0000000..bc911ba
> --- /dev/null
> +++ b/core/nano/APKBUILD
> _at_@ -0,0 +1,33 @@
> +# Contributor: ms13sp <ms13sp_at_gmail.com>
> +# Maintainer: ms13sp <ms13sp_at_gmail.com>
> +pkgname=nano
> +pkgver=2.0.9
> +pkgmaj=2.0
> +pkgrel=0
> +pkgdesc="Text Editor. GNU nano is designed to be a free replacement
> for the Pico text editor."
> +url="http://www.nano-editor.org/"
> +license="GPL"
> +depends="ncurses uclibc"
> +makedepends="ncurses-dev"
> +install=
> +subpackages="$pkgname-doc"
> +source="http://www.nano-editor.org/dist/v
> $pkgmaj/$pkgname-$pkgver.tar.gz"
> +
> +build() {
> + cd "$srcdir/$pkgname-$pkgver"
> +
> + ./configure --prefix=/usr \
> + --sysconfdir=/etc \
> + --mandir=/usr/share/man \
> + --infodir=/usr/share/info \
> + --enable-tiny \
> + --disable-nls \

I think its a good idea to use --disable-nls. I have a feeling that not
doing so migh come back and bite us later.

> + --disable-speller
> + make || return 1
> + make DESTDIR="$pkgdir" install
> +
> + # install -m755 -D "$srcdir"/$pkgname.initd
> "$pkgdir"/etc/init.d/$pkgname
> + # install -m644 -D "$srcdir"/$pkgname.confd
> "$pkgdir"/etc/conf.d/$pkgname

those lines are dead code and could be removed.

> +}
> +
> +md5sums="2be94dc43fb60fff4626a2401a977220 nano-2.0.9.tar.gz"
> --
> 1.6.1.3


I'll commit as is and move to extra.

Thank you very much!

-nc



---
Unsubscribe:  alpine-devel+unsubscribe_at_lists.alpinelinux.org
Help:         alpine-devel+help_at_lists.alpinelinux.org
---
Received on Mon Feb 23 2009 - 13:37:34 UTC