This is the follow-up to last night's patch to add rdiff-backup.
Is there some way that I should do this to make it appear as one patch? I wasn't sure of your procedure,
but since I'd already committed the first (broken) attempt locally, the second commit to fix it is a second
patch as well.
Jeremy
Okay - coming momentarily.
On Mon, Oct 25, 2010 at 10:47 AM, Natanael Copa <ncopa@alpinelinux.org>wrote:
> On Thu, 2010-10-21 at 14:37 +0000, Jeremy Thomerson wrote:> > This is the follow-up to last night's patch to add rdiff-backup.> >> > Is there some way that I should do this to make it appear as one patch?> I wasn't sure of your procedure,> > but since I'd already committed the first (broken) attempt locally, the> second commit to fix it is a second> > patch as well.>> Yes.>> Do change.> git add APBUILD> git commit --amend>> will "redo" last commit.>> Does not work if the changes are pushed to a public repository, since it> will create problems for people who have checked it out. (you rewrite> the history).>> We should update the wiki with this info. Soemthing like:> If patch is rejected on mailing list, do the suggested changes, git> commit --amend and git send-email again.>> > Jeremy> >>>>
On Thu, 2010-10-21 at 14:37 +0000, Jeremy Thomerson wrote:
> This is the follow-up to last night's patch to add rdiff-backup.> > Is there some way that I should do this to make it appear as one patch? I wasn't sure of your procedure, > but since I'd already committed the first (broken) attempt locally, the second commit to fix it is a second> patch as well.
Yes.
Do change.
git add APBUILD
git commit --amend
will "redo" last commit.
Does not work if the changes are pushed to a public repository, since it
will create problems for people who have checked it out. (you rewrite
the history).
We should update the wiki with this info. Soemthing like:
If patch is rejected on mailing list, do the suggested changes, git
commit --amend and git send-email again.
> Jeremy>
---
Unsubscribe: alpine-devel+unsubscribe@lists.alpinelinux.org
Help: alpine-devel+help@lists.alpinelinux.org
---
On Thu, 2010-10-21 at 14:37 +0000, Jeremy Thomerson wrote:
> This is the follow-up to last night's patch to add rdiff-backup.
Applied.
I did the change with 'git commit --amend' instead so it shows up as one
commit.
Thanks!
-nc
---
Unsubscribe: alpine-devel+unsubscribe@lists.alpinelinux.org
Help: alpine-devel+help@lists.alpinelinux.org
---
On Mon, 2010-10-25 at 17:57 +0200, Natanael Copa wrote:
> On Thu, 2010-10-21 at 14:37 +0000, Jeremy Thomerson wrote:> > This is the follow-up to last night's patch to add rdiff-backup.> > Applied.> > I did the change with 'git commit --amend' instead so it shows up as one> commit.
but i didnt push it. Using the one you sent, instead :)
Thanks!
-nc
---
Unsubscribe: alpine-devel+unsubscribe@lists.alpinelinux.org
Help: alpine-devel+help@lists.alpinelinux.org
---