On Mon, 11 Jul 2011 16:21:37 -0500
John Keith Hohm <john_at_hohm.net> wrote:
> Full screen ncurses traceroute tool
> testing/mtr/APKBUILD | 48 +++++
> testing/mtr/mtr-res_mkquery.patch | 374
> +++++++++++++++++++++++++++++++++++++ 2 files changed, 422
> insertions(+), 0 deletions(-) create mode 100644 testing/mtr/APKBUILD
> create mode 100644 testing/mtr/mtr-res_mkquery.patch
Looks generally good. Some minor notes below.
Since there are no mtr-dev subpackage you could have just deleted
> +++ b/testing/mtr/mtr-res_mkquery.patch
> _at_@ -0,0 +1,374 @@
> +--- a/mtr-0.80/configure
> ++++ b/mtr-0.80/configure
I had a look at this patch and, sure it works. It would have been
preferable that it could have changed the configure.in file and then
run aclocal && autoreconf or similar. Instead of error out on missing
res_mkquery it could have set a config.h variable and then do
/* res_mkquery from dietlibc libcruft http://www.fefe.de/dietlibc/
and send that patch upstream.
(even better would probably to remove the entire dns.c and use c-ares
That said, I think its good enough for Alpine anyways.
Received on Tue Jul 12 2011 - 10:20:23 UTC