Mail archive

Re: [alpine-devel] [PATCH] testing/mtr: new aport

From: John Keith Hohm <>
Date: Tue, 12 Jul 2011 11:54:48 -0500

On 07/12/2011 03:20 AM, Natanael Copa wrote:
> I had a look at this patch and, sure it works. It would have been
> preferable that it could have changed the file and then
> run aclocal&& autoreconf or similar. Instead of error out on missing
> res_mkquery it could have set a config.h variable and then do
> something like:
> #ifndef HAVE_MK_QUERY
> /* res_mkquery from dietlibc libcruft */
> ...
> #endif

Yes, I actually did something like that first locally but the patch from
re-running those tools was ridiculously big, since I did not use the
exact same automake and autoconf versions as upstream.

> and send that patch upstream.
> (even better would probably to remove the entire dns.c and use c-ares
> library)

Hey, thanks for the pointer to c-ares. Maybe I should check with
upstream whether they are likely to accept such a patch. I had first
considered replacing dns.c with the public domain djbdns client library
files but thought they might not be keen on losing IPv6 support.

> That said, I think its good enough for Alpine anyways.
> Thanks!

Thanks guys for the inclusion, and for working on Alpine. I am quite
pleased to be able to stay with Alpine for an upgrade to a new x86_64
incarnation of an important firewall.

John Keith Hohm
Received on Tue Jul 12 2011 - 11:54:48 UTC